103242 - component-specific timing dependency sections don't get run

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Curt Patrick (gone)]

When I create a subcomponent like  Component Something-Uncompress File0, the
action never happens at all.

Comment 1

[Curt Patrick (gone)]

Attachment: Sean provided this fix.

Comment 2

[Curt Patrick (gone)]

r=curt

My familiarity with the code is weak enough that the code review should be
considered pretty cursory but I applied the patch, compiled and tested it and it
works.

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 52161 [details] [diff] [review]
Sean provided this fix.

>         /* PRE_DOWNLOAD process file manipulation functions */
>         ProcessFileOps(T_PRE_DOWNLOAD, NULL);
>+        ProcessFileOpsForSelectedComponents(T_PRE_DOWNLOAD);

Everywhere you use the new ProcessFileOpsForSelectedComponents
function you put it right next to a ProcessFileOps(blah,NULL) call.
This just calls out for combining, both to simplify the code and
to minimize the chance of making the same mistake if you ever
add another timing to handle. So rename your new function something
like ProcessFileOpsForAll() and have that call ProcessFileOps() on
NULL before doing the loop. [Or use the ProcessFileOps name for
the combined function and rename the existing function to
ProcessFileOpsForComponent() -- you'd have to remember to change
the calls in xpi.c in that case, though]

If you're absolutely convinced you might need to do selected
components and NOT the global sections in the future then add
another function or macro to call this pair. But it'd be easy
enough to separate out the selected component part in the future
if you end up needing it that way.

Comment 4

[Daniel Veditz [:dveditz]]

Updating summary, it appears only pre archive and post archive timings worked
for specific components.

Comment 5

[Sean Su]

The initial patch I provided to curt was only a test because I was not able to 
test it.  Here is another one with review comments taken into account.

Comment 6

[Sean Su]

Attachment: patch #2

Comment 7

[Jaime Rodriguez, Jr.]

what are the chances that this will make the 094 branch?

Comment 8

[Jaime Rodriguez, Jr.]

looks like this is needed for http://bugscape.netscape.com/show_bug.cgi?id=9979
.

Comment 9

[Curt Patrick (gone)]

r=curt

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 52197 [details] [diff] [review]
patch #2

sr=dveditz, updating status to reflect original r=curt

Comment 11

[Jaime Rodriguez, Jr.]

pls check this into the branch - PDT+

Comment 12

[Sean Su]

Patch has landed to the branch.  waiting on trunk to open for general checkins 
before I can patch the trunk.

Comment 13

[Sean Su]

patch checked in to trunk.

Comment 14

[Jimmy Lee]

Build:  2001-10-09-10-0.9.4(WIN)

Verified on branch.  Config.ini reflects the updated section and statement.

[Component Java Patch-Uncompress File0]
Timing=post launchapp

This still needs to be verified on the TRUNK.

Comment 15

[Jimmy Lee]

Build: 2001-10-09-09-trunk(WIN)

Looks good on TRUNK as well.  Marking Verified!