1032427 - Move docshell events to inner window only

Status: RESOLVED DUPLICATE of bug 1182316

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This one is slightly tricky.  There is (potentially) a behavior change here.  Before if popstate caused a navigation we would end up firing the hashchange at the new inner window.  That seems wrong to me, so I changed it.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8448247 [details] [diff] [review]
Patch


>             // The event dispatch below can cause us to re-enter script and
>-            // destroy the docshell, nulling out mScriptGlobal. Hold a stack
>-            // reference to avoid null derefs. See bug 914521.
>-            nsRefPtr<nsGlobalWindow> win = mScriptGlobal;
>-            if (win) {
>+            // destroy the docshell, nulling out mScriptGlobal or changing the
>+            // inner window. Hold a stack reference to avoid null derefs. See
>+            // bug 914521.
>+            nsCOMPtr<nsPIDOMWindow> inner =
>+              mScriptGlobal->GetCurrentInnerWindow();
Nothing guarantees mScriptGlobal is non-null here, at least in theory.
So, null check.