Closed
Bug 1032438
Opened 10 years ago
Closed 10 years ago
Fix build warning in r_bitfield.c
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: vlad.postoaca, Assigned: vlad.postoaca)
Details
Attachments
(1 file, 1 obsolete file)
9.30 KB,
patch
|
abr
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release) Build ID: 20140608211622 Steps to reproduce: Fix build warning in mozilla-central/media/mtransport/third_party/nrappkit/src/util/libekr/r_bitfield.c
Assignee | ||
Comment 1•10 years ago
|
||
Hello. I am new here and I want to start contributing. I will submit the patch in a few moments.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8448294 -
Flags: review?(valentin.gosu)
Updated•10 years ago
|
Component: General → Video/Audio
Comment 3•10 years ago
|
||
Comment on attachment 8448294 [details] [diff] [review] Fix build warning in mozilla-central/media/mtransport/third_party/nrappkit/src/util/libekr/r_bitfield.c Hi Erik, This is Andrei's first patch. Can you help with review for this patch fixing a build warning? Thanks
Attachment #8448294 -
Flags: review?(valentin.gosu) → review?(ekr)
Comment 4•10 years ago
|
||
I don't believe this code is used in Firefox so I suggest just removing it from the build instead.
Updated•10 years ago
|
Attachment #8448294 -
Flags: review?(ekr)
Assignee | ||
Comment 5•10 years ago
|
||
So, should I remove the whole file and/or other files from the build?
Assignee | ||
Comment 6•10 years ago
|
||
In this patch I have removed r_bitfield.c and r_bitfield.h from the build.
Attachment #8449490 -
Flags: review?(ekr)
Comment 7•10 years ago
|
||
Comment on attachment 8449490 [details] [diff] [review] bug1032438_warningfixes.diff Review of attachment 8449490 [details] [diff] [review]: ----------------------------------------------------------------- kicking this to adam
Attachment #8449490 -
Flags: review?(ekr) → review?(adam)
Comment 8•10 years ago
|
||
This looks pretty reasonable; I'm running a try build to make sure we're not missing some platform-specific subtlety with the build system: https://tbpl.mozilla.org/?tree=Try&rev=3f9c584ec09e
Comment 9•10 years ago
|
||
(In reply to Eric Rescorla (:ekr) from comment #4) > I don't believe this code is used in Firefox so I suggest just removing it > from the build instead. So, when it comes to upstreaming, how do you want to handle this?
Flags: needinfo?(ekr)
Comment 10•10 years ago
|
||
Comment on attachment 8449490 [details] [diff] [review] bug1032438_warningfixes.diff Review of attachment 8449490 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks!
Attachment #8449490 -
Flags: review?(adam) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Thank you all for helping me with my first contribution.
Updated•10 years ago
|
Attachment #8448294 -
Attachment is obsolete: true
Comment 13•10 years ago
|
||
Adam, I don't think we need to upstream this, since it's just a change to Mozilla code.
Flags: needinfo?(ekr)
Comment 14•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/fd83cc89b4ad
Keywords: checkin-needed
Comment 15•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fd83cc89b4ad
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•