1032438 - Fix build warning in r_bitfield.c

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Andrei Vlad Postoaca]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

Fix build warning in mozilla-central/media/mtransport/third_party/nrappkit/src/util/libekr/r_bitfield.c

Comment 1

[Andrei Vlad Postoaca]

Hello. I am new here and I want to start contributing. I will submit the patch in a few moments.

Comment 2

[Andrei Vlad Postoaca]

Attachment: Fix build warning in mozilla-central/media/mtransport/third_party/nrappkit/src/util/libekr/r_bitfield.c

Comment 3

[Valentin Gosu [:valentin]]

Comment on attachment 8448294 [details] [diff] [review]
Fix build warning in mozilla-central/media/mtransport/third_party/nrappkit/src/util/libekr/r_bitfield.c

Hi Erik,

This is Andrei's first patch. Can you help with review for this patch fixing a build warning?

Thanks

Comment 4

[Eric Rescorla (:ekr)]

I don't believe this code is used in Firefox so I suggest just removing it from the build instead.

Comment 5

[Andrei Vlad Postoaca]

So, should I remove the whole file and/or other files from the build?

Comment 6

[Andrei Vlad Postoaca]

Attachment: bug1032438_warningfixes.diff

In this patch I have removed r_bitfield.c and r_bitfield.h from the build.

Comment 7

[Eric Rescorla (:ekr)]

Comment on attachment 8449490 [details] [diff] [review]
bug1032438_warningfixes.diff

Review of attachment 8449490 [details] [diff] [review]:
-----------------------------------------------------------------

kicking this to adam

Comment 8

[Adam Roach [:abr]]

This looks pretty reasonable; I'm running a try build to make sure we're not missing some platform-specific subtlety with the build system:

https://tbpl.mozilla.org/?tree=Try&rev=3f9c584ec09e

Comment 9

[Adam Roach [:abr]]

(In reply to Eric Rescorla (:ekr) from comment #4)
> I don't believe this code is used in Firefox so I suggest just removing it
> from the build instead.

So, when it comes to upstreaming, how do you want to handle this?

Comment 10

[Adam Roach [:abr]]

Comment on attachment 8449490 [details] [diff] [review]
bug1032438_warningfixes.diff

Review of attachment 8449490 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!

Comment 11

[Andrei Vlad Postoaca]

Thank you all for helping me with my first contribution.

Comment 12

[Valentin Gosu [:valentin]]

Good job, Andrei!

Comment 13

[Eric Rescorla (:ekr)]

Adam, I don't think we need to upstream this, since
it's just a change to Mozilla code.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fd83cc89b4ad

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd83cc89b4ad