Fix build warning in r_bitfield.c

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vlad.postoaca, Assigned: vlad.postoaca)

Tracking

unspecified
mozilla34
x86_64
Linux
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

Fix build warning in mozilla-central/media/mtransport/third_party/nrappkit/src/util/libekr/r_bitfield.c
Assignee

Comment 1

5 years ago
Hello. I am new here and I want to start contributing. I will submit the patch in a few moments.

Updated

5 years ago
Component: General → Video/Audio
Comment on attachment 8448294 [details] [diff] [review]
Fix build warning in mozilla-central/media/mtransport/third_party/nrappkit/src/util/libekr/r_bitfield.c

Hi Erik,

This is Andrei's first patch. Can you help with review for this patch fixing a build warning?

Thanks
Attachment #8448294 - Flags: review?(valentin.gosu) → review?(ekr)
I don't believe this code is used in Firefox so I suggest just removing it from the build instead.
Attachment #8448294 - Flags: review?(ekr)
Assignee

Comment 5

5 years ago
So, should I remove the whole file and/or other files from the build?
Assignee

Comment 6

5 years ago
In this patch I have removed r_bitfield.c and r_bitfield.h from the build.
Attachment #8449490 - Flags: review?(ekr)
Comment on attachment 8449490 [details] [diff] [review]
bug1032438_warningfixes.diff

Review of attachment 8449490 [details] [diff] [review]:
-----------------------------------------------------------------

kicking this to adam
Attachment #8449490 - Flags: review?(ekr) → review?(adam)

Comment 8

5 years ago
This looks pretty reasonable; I'm running a try build to make sure we're not missing some platform-specific subtlety with the build system:

https://tbpl.mozilla.org/?tree=Try&rev=3f9c584ec09e

Comment 9

5 years ago
(In reply to Eric Rescorla (:ekr) from comment #4)
> I don't believe this code is used in Firefox so I suggest just removing it
> from the build instead.

So, when it comes to upstreaming, how do you want to handle this?
Flags: needinfo?(ekr)
Comment on attachment 8449490 [details] [diff] [review]
bug1032438_warningfixes.diff

Review of attachment 8449490 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!
Attachment #8449490 - Flags: review?(adam) → review+
Assignee

Comment 11

5 years ago
Thank you all for helping me with my first contribution.
Good job, Andrei!
Assignee: nobody → vlad.postoaca
Keywords: checkin-needed
Attachment #8448294 - Attachment is obsolete: true
Adam, I don't think we need to upstream this, since
it's just a change to Mozilla code.
Flags: needinfo?(ekr)
https://hg.mozilla.org/mozilla-central/rev/fd83cc89b4ad
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.