1032482 - Render connections only once

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: multiconnect-wae.png

While creating a beautiful image, the web audio editor should not render connections to another audio node multiple times, even if node.connect(otherNode) is called several times.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1032482-redundant-connection-render.patch

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8448972 [details] [diff] [review]
1032482-redundant-connection-render.patch

Review of attachment 8448972 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the comment below.

::: browser/devtools/webaudioeditor/webaudioeditor-controller.js
@@ +104,5 @@
>      AudioNodeConnections.set(this, connections);
>    }
> +
> +  // Don't duplicate add.
> +  if (!~connections.indexOf(destination)) {

Maybe using a Set for the connections would've been nicer than an array? I'd suggest doing this small refactoring if time permits.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1032482-redundant-connection-render.patch

Now with sets

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=22e8c0837cf1

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/480d3f283c9d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/480d3f283c9d