Change the webidl hook to allow commits authored by a DOM reviewer

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bz, Assigned: Ehsan)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Because the point is for one of them to have looked at the code, and if they wrote it, they looked at it.  Relevant mail list, afaict:

jst@mozilla.com
peterv@propagandism.org
bzbarsky@mit.edu
jonas@sicking.cc
Olli.Pettay@helsinki.fi
bent.mozilla@gmail.com
mounir@lamouri.fr
khuey@kylehuey.com
justin.lebar@gmail.com
hsivonen@hsivonen.fi
mrbkap@gmail.com
Flags: needinfo?(ehsan)

Updated

3 years ago
Blocks: 1001106
Created attachment 8449841 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #8449841 - Flags: review?(ted)
Flags: needinfo?(ehsan)
Comment on attachment 8449841 [details] [diff] [review]
Patch (v1)

Review of attachment 8449841 [details] [diff] [review]:
-----------------------------------------------------------------

You might want to note in the comment in the file that the intent is that a DOM peer has looked at the changes.

::: mozhghooks/prevent_webidl_changes.py
@@ +58,5 @@
> +        'khuey@kylehuey.com',      # Kyle Huey
> +        'justin.lebar@gmail.com',  # Justin Lebar
> +        'hsivonen@hsivonen.fi',    # Henri Sivonen
> +        'mrbkap@gmail.com',        # Blake Kaplan
> +    ]

Seems silly to have two separate lists, but whatever floats your boat.

@@ +78,5 @@
>          for file in c.files():
>              # Only Check WebIDL Files
>              if file.endswith('.webidl'):
>                  message = c.description().lower()
> +                user = c.user().lower()

You can do:
from mercurial import util
email = util.email(c.user())
Attachment #8449841 - Flags: review?(ted) → review+
http://hg.mozilla.org/hgcustom/hghooks/rev/a7ff9c6c9e69
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Depends on: 1037123
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.