1032531 - Change the webidl hook to allow commits authored by a DOM reviewer

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Because the point is for one of them to have looked at the code, and if they wrote it, they looked at it.  Relevant mail list, afaict:

[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8449841 [details] [diff] [review]
Patch (v1)

Review of attachment 8449841 [details] [diff] [review]:
-----------------------------------------------------------------

You might want to note in the comment in the file that the intent is that a DOM peer has looked at the changes.

::: mozhghooks/prevent_webidl_changes.py
@@ +58,5 @@
> +        '[e-mail]',      # Kyle Huey
> +        '[e-mail]',  # Justin Lebar
> +        '[e-mail]',    # Henri Sivonen
> +        '[e-mail]',        # Blake Kaplan
> +    ]

Seems silly to have two separate lists, but whatever floats your boat.

@@ +78,5 @@
>          for file in c.files():
>              # Only Check WebIDL Files
>              if file.endswith('.webidl'):
>                  message = c.description().lower()
> +                user = c.user().lower()

You can do:
from mercurial import util
email = util.email(c.user())

Comment 3

[(no longer active)]

http://hg.mozilla.org/hgcustom/hghooks/rev/a7ff9c6c9e69