Closed
Bug 1032557
Opened 11 years ago
Closed 11 years ago
Synchronize logic for collections
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(b2g-v1.4 unaffected, b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S5 (4july)
| Tracking | Status | |
|---|---|---|
| b2g-v1.4 | --- | unaffected |
| b2g-v2.0 | --- | fixed |
| b2g-v2.1 | --- | fixed |
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
crdlc
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details | Review |
It may be possible to have an outdated local database in some cases for collections. This should probably only be possible due to platform bugs currently, but this is needed for when we have replaceable homescreens.
|
Assignee | |
Updated•11 years ago
|
Blocks: vertical-home-next
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8448389 [details] [review]
WIP - github pull request
Cristian - could you review this? This is in case the local indexed DB gets out of sync with the CollectionsDatastore. I thought that datastore would take care of this for us, but it appears that we still need this. This is basically the same logic as the bookmarks source.
Attachment #8448389 -
Flags: review?(crdlc)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8448389 [details] [review]
WIP - github pull request
The code LGTM. I wrote just a comment in github. Other idea that we could take a look is the revisionId. I did it for bookmarks in the old-home. If the revisionId is the same in home and bookmarks datastore we won't need to synchronize anything. Otherwise we should synchronize when revisionIds are different.
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/bookmark.js#L63
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid.js#L983
Attachment #8448389 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8448389 [details] [review]
WIP - github pull request
This is needed for the vertical homescreen.
Attachment #8448389 -
Flags: approval-gaia-v2.0?(bbajaj)
|
||
Updated•11 years ago
|
Attachment #8448389 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
|
|
||
Updated•11 years ago
|
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
||
Comment 7•11 years ago
|
||
Hi Reporter,
Could you provide the detailed reproduce steps for me to verify this bug?
Thank you!
Flags: needinfo?(kgrandon)
|
|
Assignee | |
Comment 8•11 years ago
|
||
There is nothing here to verify, consider it infrastructure stuff.
Flags: needinfo?(kgrandon)
You need to log in
before you can comment on or make changes to this bug.
Description
•