1032592 - Allow principals to be sent with the message manager

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P1)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: sc-principals

The message manager uses structured clone, so this patch adds structured clone support for nsIPrincipal. It's based on the patch in bug 1024098.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: sc-principals v2

New patch!

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8452820 [details] [diff] [review]
sc-principals v2

Review of attachment 8452820 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks!

::: dom/base/nsJSEnvironment.cpp
@@ +2918,5 @@
> +      }
> +
> +      if (info.type() == mozilla::ipc::PrincipalInfo::TNullPrincipalInfo) {
> +        return JS_WriteUint32Pair(writer, SCTAG_DOM_NULL_PRINCIPAL, 0);
> +      } else if (info.type() == mozilla::ipc::PrincipalInfo::TSystemPrincipalInfo) {

Nit: else after return, twice here.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4f7e17a607f

Comment 5

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/b4f7e17a607f

Comment 6

[Mike Conley (:mconley) (:⚙️)]

We should probably update the docs in https://developer.mozilla.org/en-US/docs/The_message_manager about sending Principals around.