1032618 - [traceback] TypeError: count() takes exactly one argument (0 given)

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://oneanddone.mozilla.org/en-US/tasks/available/?search=^^^^&execution_time=%2527&project=1&team=1&type=1 throws:

Traceback (most recent call last):
File "/app/app/vendor/lib/python/django/core/handlers/base.py", line 136, in get_response response = response.render()
File "/app/app/vendor/lib/python/django/template/response.py", line 104, in render self._set_content(self.rendered_content)
File "/app/app/vendor/lib/python/django/template/response.py", line 81, in rendered_content content = template.render(context)
File "/app/app/vendor/src/jingo/jingo/__init__.py", line 189, in render return super(Template, self).render(context_dict)
File "/opt/ActivePython-2.7/lib/python2.7/site-packages/newrelic-1.11.0.55/newrelic/api/object_wrapper.py", line 216, in __call__ self._nr_instance, args, kwargs)
File "/opt/ActivePython-2.7/lib/python2.7/site-packages/newrelic-1.11.0.55/newrelic/api/function_trace.py", line 82, in dynamic_wrapper return wrapped(*args, **kwargs)
File "/app/python/lib/python2.7/site-packages/jinja2/environment.py", line 891, in render return self.environment.handle_exception(exc_info, True)
File "/app/app/oneanddone/tasks/templates/tasks/list.html", line 6, in top-level template code {% set title = _('Tasks') %}
File "/app/app/oneanddone/base/templates/base/base.html", line 86, in top-level template code {% block content %}{% endblock %}
File "/app/app/oneanddone/tasks/templates/tasks/list.html", line 13, in block "content" {% include 'tasks/task_listing.html' %}
File "/app/app/oneanddone/tasks/templates/tasks/task_listing.html", line 10, in top-level template code {% if tasks.count() %}
TypeError: count() takes exactly one argument (0 given)

[1] https://rpm.newrelic.com/accounts/263620/applications/3612614/traced_errors/1836906564

Comment 1

[Rebecca Billings [:rbillings]]

What are the steps to repro? It looks like the execution time is the issue, as there is no option for the time you have- there is only 15/30/45/60, as opposed to the slider in the previous version.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Rebecca Billings [:rbillings] from comment #1)
> What are the steps to repro? It looks like the execution time is the issue,
> as there is no option for the time you have- there is only 15/30/45/60, as
> opposed to the slider in the previous version.

This was from a fuzzer; sorry for not noting/marking that in the whiteboard, which I've now done.  I doubt you can get this from the UI, so it's manual/automation-manipulated.

Comment 3

[Bob Silverberg [:bsilverberg]]

So are you the one generating all those requests, Stephen? I've seen the error messages, and plan on addressing them this week. This is not something that a user would experience, as it's a result of passing invalid data via the url. Ideally it wouldn't throw an error internally, and that's what I'm planning on addressing, but as it stands all the user would see if they were to intentionally pass bad data on the url is the standard error page.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Bob Silverberg [:bsilverberg] from comment #3)
> So are you the one generating all those requests, Stephen? I've seen the
> error messages, and plan on addressing them this week. This is not something
> that a user would experience, as it's a result of passing invalid data via
> the url. Ideally it wouldn't throw an error internally, and that's what I'm
> planning on addressing, but as it stands all the user would see if they were
> to intentionally pass bad data on the url is the standard error page.

I hope so, and hopefully they've stopped, because I haven't run any fuzzing today at all.  And, yes, lower priority, obviously, than real problems which users would see in a practical scenario -- a standard error page (even within Web dev, they don't standardize on what to return -- 400, 404, etc.)

Comment 5

[Bob Silverberg [:bsilverberg]]

The fix for this landed in https://github.com/mozilla/oneanddone/commit/37887c431e1a42dd0fcd61d3e29e260cd25c3b1f

Stephen, can you try running your fuzzer again? It should generate fewer (hopefully zero) errors this time.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, Bob!

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screen Shot 2014-07-01 at 10.25.49 PM.png

For reference, the Windows-based tool I used to find and verify this is "Powerfuzzer"

Comment 8

[Bob Silverberg [:bsilverberg]]

Hooray! Thanks for verifying, Stephen.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Bob Silverberg [:bsilverberg] from comment #8)
> Hooray! Thanks for verifying, Stephen.

NP; and sorry for testing on prod!  I should've known better :-(