Closed Bug 1032804 Opened 6 years ago Closed 6 years ago

Classic Theme is missing dummy chome.manifest file (and icon.png, and preview.png)

Categories

(SeaMonkey :: Themes, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.30

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

(Keywords: classic, regression)

Attachments

(1 file, 1 obsolete file)

Error Console message:

Could not read chrome manifest 'jar:file:///C:/T1/hg/objdir-sm/mozilla/dist/seamonkey/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D.xpi!/chrome.manifest'.
Attached patch Patch v1.0 Proposed fix. (obsolete) — Splinter Review
> +libs:: $(FILES)
> +	$(INSTALL) $(foreach f,$^,"$f") $(DIST)/bin/extensions/$(CLASSIC_EXTENSION_DIR)
> +
> +install:: $(FILES)
> +	$(SYSINSTALL) $(IFLAGS1) $(foreach f,$^,"$f") $(DESTDIR)$(mozappdir)/extensions/$(CLASSIC_EXTENSION_DIR)

I copied these lines from Thunderbird.
Attachment #8448721 - Flags: review?(neil)
Comment on attachment 8448721 [details] [diff] [review]
Patch v1.0 Proposed fix.

I assume the right place to copy them is from glandium's inadvertent deletion in comm-central changeset 42b421a3887b. Alternatively you could look into switching this file to use INSTALL_TARGETS and/or PP_TARGETS.
Attachment #8448721 - Flags: review?(neil) → review-
Blocks: 937212
Keywords: regression
> I assume the right place to copy them is from glandium's inadvertent 
> deletion in comm-central changeset 42b421a3887b. Alternatively you could 
> look into switching this file to use INSTALL_TARGETS and/or PP_TARGETS.

I had a look at INSTALL_TARGETS and/or PP_TARGETS but in the interest of parsimony I'm just reverting the change from c-c 42b421a3887b.
Attachment #8448721 - Attachment is obsolete: true
Attachment #8450392 - Flags: review?(neil)
Attachment #8450392 - Flags: review?(neil) → review+
Pushed comm-central changeset 5611f67e859c
http://hg.mozilla.org/comm-central/rev/5611f67e859c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.30
You need to log in before you can comment on or make changes to this bug.