1032804 - Classic Theme is missing dummy chome.manifest file (and icon.png, and preview.png)

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Philip Chee]

Error Console message:

Could not read chrome manifest 'jar:file:///C:/T1/hg/objdir-sm/mozilla/dist/seamonkey/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D.xpi!/chrome.manifest'.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix.

> +libs:: $(FILES)
> +	$(INSTALL) $(foreach f,$^,"$f") $(DIST)/bin/extensions/$(CLASSIC_EXTENSION_DIR)
> +
> +install:: $(FILES)
> +	$(SYSINSTALL) $(IFLAGS1) $(foreach f,$^,"$f") $(DESTDIR)$(mozappdir)/extensions/$(CLASSIC_EXTENSION_DIR)

I copied these lines from Thunderbird.

Comment 2

[[e-mail]]

Comment on attachment 8448721 [details] [diff] [review]
Patch v1.0 Proposed fix.

I assume the right place to copy them is from glandium's inadvertent deletion in comm-central changeset 42b421a3887b. Alternatively you could look into switching this file to use INSTALL_TARGETS and/or PP_TARGETS.

Comment 3

[Philip Chee]

Attachment: Patch v2.0 Revert change from c-c changeset 42b421a3887b

> I assume the right place to copy them is from glandium's inadvertent 
> deletion in comm-central changeset 42b421a3887b. Alternatively you could 
> look into switching this file to use INSTALL_TARGETS and/or PP_TARGETS.

I had a look at INSTALL_TARGETS and/or PP_TARGETS but in the interest of parsimony I'm just reverting the change from c-c 42b421a3887b.

Comment 4

[Philip Chee]

Pushed comm-central changeset 5611f67e859c
http://hg.mozilla.org/comm-central/rev/5611f67e859c