1032813 - [L10n][Contacts] Clean up mozL10n.get uses in Contacts app

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Michał Budzyński (:michalbe)]

This is a Contacts follow up for meta Bug 1020138. As described there:

It's all about grepping for "mozL10n.get" use cases and if it's simple:

var text = navigator.mozL10n.get(l10nId);
node.textContent = text;

replacing it with:

node.setAttribute('data-l10n-id', l10nId);

Comment 2

[Akshat Kedia [:aks]]

Hey,

I will like to work on this bug. Can you tell me which file/folder I need to grep ? 

Thanks.

Comment 3

[Michał Budzyński (:michalbe)]

Hi Akshat,

You can find contacts app in apps/communications/contacts. This bug is a little bit more than just grepping and replacing strings, it will need small changes in a logic as well (like every use of TAG_OPTIONS - this object is localized).

Comment 4

[Sudheesh Singanamalla (:ShellHacker)]

Can I be assigned to work on this ? Looks like Akshat's probably caught up.

Comment 5

[Sudheesh Singanamalla (:ShellHacker)]

Can I be assigned to work on this ? Looks like Akshat's probably caught up.

Comment 6

[Akshat Kedia [:aks]]

Go ahead take it on.

Comment 7

[Sudheesh Singanamalla (:ShellHacker)]

Thanks Akshat :+1:
Taking this bug to work on.

Comment 8

[Sudheesh Singanamalla (:ShellHacker)]

(In reply to Michał Budzyński (:michalbe) from comment #1)

> var text = navigator.mozL10n.get(l10nId);
> node.textContent = text;
> 
> replacing it with:
> 
> node.setAttribute('data-l10n-id', l10nId);

In case its an underscore instead of text, should and the usage is just mozL10n.get; should the replacement be

node.setAttribute('data-l10n-id',''); ?

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

I think we will need to use the |translate| method, but not so sure, Michal what do you think?

Comment 10

[Michał Budzyński (:michalbe)]

Underscore & mozL10N.get() is the same function, we don't want to use it in the code anymore, instead we just set correct attributes on DOM nodes.

Comment 11

[Sudheesh Singanamalla (:ShellHacker)]

I am not clear about this, since the get(<param>) is translated to node.setAttribute('data-l10n-id','<param>'); , having no parameter, makes the param part be a null string ? ('') ?

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

There should be no place where we do mozL10n.get(''); That's a clear error, since the function cannot receive an empty l10n identifier.

Comment 13

[Sudheesh Singanamalla (:ShellHacker)]

So how should the var _ = mozL10n.get; be converted to, this is the problem that I am facing.

Comment 14

[Sudheesh Singanamalla (:ShellHacker)]

NI'ing

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Closing as wontfix since this cleanup already happened.