1032875 - move empty gethashUrl check to after getting the table completer

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

Otherwise on startup, listmanager may be null and gethashUrl may be empty and crash on toolkit/components/url-classifier/nsUrlClassifierDBService.cpp:843

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Move empty gethash URL check in case listmanager is not ready (

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8448816 [details] [diff] [review]
Move empty gethash URL check in case listmanager is not ready (

Review of attachment 8448816 [details] [diff] [review]:
-----------------------------------------------------------------

So what you're saying is that we're being asked to classify URLs before SafeBrowsing is fully initialized, and it's getting *hits that need to be gethashed*, but we can't because we're not initialized?

That seems bad. Why does this happen? I'm assuming its on one of the whitelist+dontcomplete tables, and the GetCompleter check fixes this because it will exempt them?

I guess it makes sense that if there's no Completer there won't be a gethash URL, though? But what's the relation to startup then? I'm slightly confused here.

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

I think what is happening is that nsUrlClassifierDBService.cpp is reading preference browser.safebrowsing.enabled before listmanager gets initialized. Then if it finds a hit in an existing table, it goes ahead and tries to get listmanager, which may be initialized but before registerTable is called.

Then the gethashURL isn't set for that table and DBService crashes.

Comment 4

[[:mmc] Monica Chew (no longer reading bugmail)]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/6598283d4cc8

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6598283d4cc8