1032911 - [B2G][E.Me]E.Me search text field overlaps 'Add to Homescreen' window, prevents user from backing out of action

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: StuckOnAddToHomescreen.txt

After typing a search term in Everything.Me, the user can long press on the search results in order to add them to the homescreen. The add to homescreen window is displayed, and the E.Me search bar is displayed over the top of the page. The search bar blocks the 'x' button, and the only way to exit this page is to add the item to homescreen. User cannot perform another search until this page has been dismissed.

The issue only occurs when the search term is typed in. This issue does not occur when performing a smart search

Repro Steps:
1) Update a Flame to BuildID: 20140701000201
2) Tap on E.Me search text bar
3) Type  'imdb' into the search bar and wait for results to populate
4) Long press on imdb e.me result
5) Tap 'Add to homescreen'

*note: imdb is just an example. this issue occurs on most search results.

Actual:
Add to Homescreen window is displayed, E.Me search bar prevents user from hitting back button

Expected:
E.Me bar is not visible in this window. User can press 'x' button to cancel adding to homescreen

v2.0 Environmental Variables:
Device: Flame v2.0 MOZ
BuildID: 20140701000201
Gaia: 8fb5e2a9ad1025ee7d247b90af7499766afadd28
Gecko: 5da69a493324
Version: 32.0a2
Firmware Version: v122

Notes:
Repro frequency: 100%
See attached: screenshot, logcat

Comment 1

[Ross Kuhlman ([e-mail])]

Attachment: SearchOverlapsBack.png

Comment 2

[Ross Kuhlman ([e-mail])]

adding qawanted to determine if issue occurs on v1.4 and Master(2.1)

Comment 3

[Peter Bylenga [:PBylenga]]

Branch checks to confirm it's a regression, but nomming to block as it breaks e.me search functionality until user adds the result to the homescreen due to lacking access to cancel flow.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Flame 2.1 master (no repro)

Issue does NOT occur on Flame 2.1 master, and does NOT occur on Flame 1.4.

2.1 behavior: See attached photo (screenshot can't be taken on this screen).
1.4 behavior: This particular screen is NOT present when adding an e.me item to homescreen. At step 5 of comment 0, if user selects to add to homescreen, the item is then added to homescreen without being provided option to edit name and address.

Device: Flame
Build ID: 20140701063753
Gaia: 34a52e7f024cc3d0e3aade94970773d2555f5ccb
Gecko: ffb8b976548b
Version: 33.0a1 (Master)
Firmware Version: B1TC00011220
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Device: Flame
Build ID: 20140630193052
Gaia: bf5ad311b6a14383924d6a3898c650ffa4525840
Gecko: 6817b6858ccf
Version: 30.0 (1.4)
Firmware Version: B1TC00011220
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

-----

Issue occurs on Buri 2.0 exactly the same way as bug reported.

Device: Buri
Build ID: 20140701090653
Gaia: 8fb5e2a9ad1025ee7d247b90af7499766afadd28
Gecko: c96dec196ae6
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 5

[Joshua Mitchell (Inactive)]

QA-Wanted - regression window wanted - *note - needs to be done in 2.0 branch as issue does not repro in 2.1

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

Hamachi 2.0 Aurora branch regression window:

Last Working Environmental Variables:
Device: Buri
BuildID: 20140630085228
Gaia: 564ab3935206a6979b317597020f47aebe8c80fe
Gecko: 7974d58adda4
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

First Broken Environmental Variables:
Device: Buri
Build ID: 20140630091128
Gaia: 2b7899cc6f4af0ed3e10ecc6531963f891cd5d06
Gecko: 0e5cf6c3f6da
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

First broken gecko & last working gaia - issue does NOT reproduce
Gaia: 564ab3935206a6979b317597020f47aebe8c80fe
Gecko: 0e5cf6c3f6da

First broken gaia & last working gecko - issue DOES reproduce
Gaia: 2b7899cc6f4af0ed3e10ecc6531963f891cd5d06
Gecko: 7974d58adda4

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/564ab3935206a6979b317597020f47aebe8c80fe...2b7899cc6f4af0ed3e10ecc6531963f891cd5d06

Possibly broken by bug 1030923? Though it seems a bit odd to me that the bug would only occur on 2.0 and not on 2.1 master.

Comment 7

[Joshua Mitchell (Inactive)]

Hi Kevin - this pushlog is all your stuff, would you mind taking a look?

Comment 8

[Kevin Grandon :kgrandon]

I believe we are just waiting on uplift here. We uplifted a lot, and I think this should be fixed by tomorrow. I will try verifying tonight on the latest 2.0 to see if it's fixed. If so, it will be in the build tomorrow.

Comment 9

[Jason Smith [:jsmith]]

If this no longer reproduces post the uplifts suggested in comment 8, then feel free to close this bug. I'll + this for now because we know we wouldn't ship with this bug.

Comment 10

[Kevin Grandon :kgrandon]

I just tested the latest master and 2.0 builds and it works properly on both. I think our uplifts today fixed this, marking as fixed, and I think it was bug 1030248 that fixed this, but not entirely sure.