Closed
Bug 1032966
Opened 10 years ago
Closed 10 years ago
Accept old format for the parameters
Categories
(Hello (Loop) :: Server, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: alexis+bugs, Assigned: rhubscher)
Details
(Whiteboard: [qa?])
Attachments
(1 file)
Make the server accept old names for the parameters (simple_push_urls and call_url) to ease the transition period.
|
||
Updated•10 years ago
|
Whiteboard: [qa?]
|
Assignee | |
Updated•10 years ago
|
QA Contact: rhubscher
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8451702 -
Flags: review?(alexis+bugs)
|
|
Assignee | |
Comment 2•10 years ago
|
||
On server side we should accept simple_push_url and simplePushURL. The callUrl vs call_url modification should be handled on client side.
Status: NEW → ASSIGNED
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8451702 [details] [review] Link to github PR r+ with nits.
Attachment #8451702 -
Flags: review?(alexis+bugs) → review+
|
|
Reporter | |
Comment 4•10 years ago
|
||
I believe the call_url should also be returned by the server in the meantime, otherwise old cilents will stop working.
|
|
Assignee | |
Comment 5•10 years ago
|
||
I don't like the idea of keeping the call_url but I have added it to the PR to handle previous nightly user. We should make sure this get away before production users.
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → rhubscher
QA Contact: rhubscher
|
|
Reporter | |
Comment 6•10 years ago
|
||
https://github.com/mozilla-services/loop-server/commit/3ef935db665d76702aa51096ad96f3eafb1128af
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•10 years ago
|
||
This seems to be working fine when comparing Beta, Aurora, Nightly Loop versions...
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•