Closed Bug 1033000 Opened 5 years ago Closed 5 years ago

Fix Yahoo search codes

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 33
Tracking Status
firefox31 --- verified
firefox32 --- verified
firefox33 --- verified
fennec 31+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(1 file)

Attached patch yahoo-codes v0.1Splinter Review
We are using the wrong Yahoo "fr" code. This patch updates it. I'll look into bug 997502 for adding tests.
Attachment #8448932 - Flags: review?(rnewman)
Comment on attachment 8448932 [details] [diff] [review]
yahoo-codes v0.1

Review of attachment 8448932 [details] [diff] [review]:
-----------------------------------------------------------------

Also need to fix locales. I see about 25 with the old tag.
Attachment #8448932 - Flags: review?(rnewman) → review+
I'm happy to script the change to the l10n-aurora repos, if that's acceptable.
Assignee: nobody → mark.finkle
Status: NEW → ASSIGNED
tracking-fennec: --- → 31+
OS: Linux → Android
Hardware: x86_64 → All
(In reply to Richard Newman [:rnewman] from comment #2)
> I'm happy to script the change to the l10n-aurora repos, if that's
> acceptable.

NI'ing Francesco for that info
Flags: needinfo?(francesco.lodolo)
Comment on attachment 8448932 [details] [diff] [review]
yahoo-codes v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Mozilla codes for Yahoo searches are wrong
[Describe test coverage new/current, TBPL]: Manual. automated tests don't exist yet.
[Risks and why]: No worse than the wrong codes we are shipping now
[String/UUID change made/needed]: None
Attachment #8448932 - Flags: approval-mozilla-beta?
Attachment #8448932 - Flags: approval-mozilla-aurora?
(In reply to Richard Newman [:rnewman] from comment #2)
> I'm happy to script the change to the l10n-aurora repos, if that's
> acceptable.

Answered in the mail thread. First: I'm still not sure that's the right tag for locales, and I want a real/clear answer about that.

Second: the less people touch those repos, the happier I am. Given that I have already people nagging me for landing fixes in their repositories
https://groups.google.com/forum/#!topic/mozilla.dev.l10n/UFWvprwjQsQ
Flags: needinfo?(francesco.lodolo)
Blocks: 1033156
Attachment #8448932 - Flags: approval-mozilla-beta?
Attachment #8448932 - Flags: approval-mozilla-beta+
Attachment #8448932 - Flags: approval-mozilla-aurora?
Attachment #8448932 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/6703bf831ab1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Verified as fixed in builds:
- 33.0a1 (2014-07-15);
- 32.0a2 (2014-07-15);
- 31 Beta 10;
Device: Google Nexus 7 (Android 4.4.4).
You need to log in before you can comment on or make changes to this bug.