1033000 - Fix Yahoo search codes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: yahoo-codes v0.1

We are using the wrong Yahoo "fr" code. This patch updates it. I'll look into bug 997502 for adding tests.

Comment 1

[Richard Newman [:rnewman]]

Comment on attachment 8448932 [details] [diff] [review]
yahoo-codes v0.1

Review of attachment 8448932 [details] [diff] [review]:
-----------------------------------------------------------------

Also need to fix locales. I see about 25 with the old tag.

Comment 2

[Richard Newman [:rnewman]]

I'm happy to script the change to the l10n-aurora repos, if that's acceptable.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Richard Newman [:rnewman] from comment #2)
> I'm happy to script the change to the l10n-aurora repos, if that's
> acceptable.

NI'ing Francesco for that info

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/6703bf831ab1

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8448932 [details] [diff] [review]
yahoo-codes v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Mozilla codes for Yahoo searches are wrong
[Describe test coverage new/current, TBPL]: Manual. automated tests don't exist yet.
[Risks and why]: No worse than the wrong codes we are shipping now
[String/UUID change made/needed]: None

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Richard Newman [:rnewman] from comment #2)
> I'm happy to script the change to the l10n-aurora repos, if that's
> acceptable.

Answered in the mail thread. First: I'm still not sure that's the right tag for locales, and I want a real/clear answer about that.

Second: the less people touch those repos, the happier I am. Given that I have already people nagging me for landing fixes in their repositories
https://groups.google.com/forum/#!topic/mozilla.dev.l10n/UFWvprwjQsQ

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6703bf831ab1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/234b0fa642ad

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a2c762fb74a2

Comment 10

[Flaviu Cos]

Verified as fixed in builds:
- 33.0a1 (2014-07-15);
- 32.0a2 (2014-07-15);
- 31 Beta 10;
Device: Google Nexus 7 (Android 4.4.4).