Closed Bug 1033049 Opened 7 years ago Closed 7 years ago
Popup Dialog appears after first character typed if it already appeared before and was not dismissed
1. flash device 2. tap rocketbar 3. type qas 4. type close 5. tap rocketbar 6. tap q Expected: popup dialog appears after 2 more characters are typed Actual: popup dialog appears after first character type Note: 1. purpose of the 3 characters was so that we don't collide with the geolocation notification overlay, we can still collide with it via having the geolocation set to Ask Gaia 34a52e7f024cc3d0e3aade94970773d2555f5ccb Gecko https://hg.mozilla.org/mozilla-central/rev/ffb8b976548b BuildID 20140701072955 Version 33.0a1 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 B1TC00011220 Flame
7 years ago
What popup dialog? Can be more specific?
It's the popup dialog for first time use : ie bug 1033041
Flags: needinfo?(nhirata.bugzilla) → needinfo?(kgrandon)
From the spec, the popup is not supposed to appear until the user types three characters.
I think I planned to fix this in another patch that didnt land, will fix now
Assignee: nobody → dale
Comment on attachment 8450582 [details] [review] https://github.com/mozilla-b2g/gaia/pull/21370 I left a comment about the offline error handling, but this mostly looks fine. Thanks!
Attachment #8450582 - Flags: review?(kgrandon) → review+
Error handling will go in another patch: https://github.com/mozilla-b2g/gaia/commit/b9afcf17134bc1eb473b0cb48aadc83fec84192c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
Flagging, this is part of the series of fixes in https://bugzilla.mozilla.org/show_bug.cgi?id=1033041 which fixes the implementation of the notice according to the specification
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-] → [VH-FL-blocking-][VH-FC-blocking+]
Verified on : Gaia 09642e74e250fbc62db860c808ef188628fca55d Gecko https://hg.mozilla.org/mozilla-central/rev/f93c0ef45597 BuildID 20140710071928 Version 33.0a1 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 B1TC00011220 Need to check 2.0 when it lands.
Gaia 5f8b1b8a2da9e3b531eee817a669f57fa4d9b9c6 Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/913827496f65 BuildID 20140716000201 Version 32.0a2 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 B1TC00011220 Flame verified. I noticed that past 4 characters the popup dialog will disappear on it's own. Need to check 2.1.
Figured it out, it's due to search suggestions not being listed for that search. emailed francis + dale offline about the situation. It might not be a bug.
You need to log in before you can comment on or make changes to this bug.