1033049 - Popup Dialog appears after first character typed if it already appeared before and was not dismissed.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. flash device
2. tap rocketbar
3. type qas
4. type close
5. tap rocketbar
6. tap q

Expected: popup dialog appears after 2 more characters are typed
Actual: popup dialog appears after first character type 

Note: 
1. purpose of the 3 characters was so that we don't collide with the geolocation notification overlay, we can still collide with it via having the geolocation set to Ask

Gaia      34a52e7f024cc3d0e3aade94970773d2555f5ccb
Gecko     https://hg.mozilla.org/mozilla-central/rev/ffb8b976548b
BuildID   20140701072955
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220
Flame

Comment 1

[Jason Smith [:jsmith]]

What popup dialog? Can be more specific?

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It's the popup dialog for first time use : ie bug 1033041

Comment 3

[Kevin Grandon :kgrandon]

From the spec, the popup is not supposed to appear until the user types three characters.

Comment 4

[Dale Harvey (:daleharvey)]

I think I planned to fix this in another patch that didnt land, will fix now

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/21370

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8450582 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21370

I left a comment about the offline error handling, but this mostly looks fine. Thanks!

Comment 7

[Dale Harvey (:daleharvey)]

Error handling will go in another patch: https://github.com/mozilla-b2g/gaia/commit/b9afcf17134bc1eb473b0cb48aadc83fec84192c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df859762e04f

Comment 9

[Dale Harvey (:daleharvey)]

Flagging, this is part of the series of fixes in https://bugzilla.mozilla.org/show_bug.cgi?id=1033041 which fixes the implementation of the notice according to the specification

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified on : 
Gaia      09642e74e250fbc62db860c808ef188628fca55d
Gecko     https://hg.mozilla.org/mozilla-central/rev/f93c0ef45597
BuildID   20140710071928
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Need to check 2.0 when it lands.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/8a7dad7b802d625263ff90aabf75a016f4b96f1d

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gaia      5f8b1b8a2da9e3b531eee817a669f57fa4d9b9c6
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/913827496f65
BuildID   20140716000201
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220
Flame

verified.  I noticed that past 4 characters the popup dialog will disappear on it's own.  Need to check 2.1.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Figured it out, it's due to search suggestions not being listed for that search.  emailed francis + dale offline about the situation.  It might not be a bug.