1033052 - Call SetRect from LineLayout::ReflowFrame instead of SetSize

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[sgbowen]

Since it's no longer necessary to preserve the old frame rect for invalidation, the rect can be set in LineLayout::ReflowFrame so that the position of the frame is available earlier.

Comment 1

[sgbowen]

Attachment: setrect.patch v1

This change resolved some problems I had while writing reflow code for CSS ruby.

Link to try run:
https://tbpl.mozilla.org/?tree=Try&rev=a95eb6d93ddc

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8449020 [details] [diff] [review]
setrect.patch v1

r=dbaron.

Best to get this in sooner rather than later, in case it breaks anything, so you don't build things depending on it if it won't work.

Definitely needs a try run before landing, though.

Comment 3

[sgbowen]

I accidentally pushed some extra patches in the last try run.

Here is the try run with this patch alone:
https://tbpl.mozilla.org/?tree=Try&rev=7200ff7a73e0

The Android 2.3 reftests have been pending overnight for some reason. Are we clear to check-in, or should I try to figure out why they're not running?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

You're good to check in; you've got reftests on Android 4.0, Mac, and Linux.  (Probably best to cancel the pending ones.)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/290b06120a69

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/290b06120a69