Closed Bug 1033052 Opened 8 years ago Closed 8 years ago

Call SetRect from LineLayout::ReflowFrame instead of SetSize

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: sgbowen8, Assigned: sgbowen8)

References

Details

Attachments

(1 file)

Since it's no longer necessary to preserve the old frame rect for invalidation, the rect can be set in LineLayout::ReflowFrame so that the position of the frame is available earlier.
Attached patch setrect.patch v1Splinter Review
This change resolved some problems I had while writing reflow code for CSS ruby.

Link to try run:
https://tbpl.mozilla.org/?tree=Try&rev=a95eb6d93ddc
Attachment #8449020 - Flags: review?(dbaron)
Comment on attachment 8449020 [details] [diff] [review]
setrect.patch v1

r=dbaron.

Best to get this in sooner rather than later, in case it breaks anything, so you don't build things depending on it if it won't work.

Definitely needs a try run before landing, though.
Attachment #8449020 - Flags: review?(dbaron) → review+
I accidentally pushed some extra patches in the last try run.

Here is the try run with this patch alone:
https://tbpl.mozilla.org/?tree=Try&rev=7200ff7a73e0

The Android 2.3 reftests have been pending overnight for some reason. Are we clear to check-in, or should I try to figure out why they're not running?
Flags: needinfo?(dbaron)
You're good to check in; you've got reftests on Android 4.0, Mac, and Linux.  (Probably best to cancel the pending ones.)
Flags: needinfo?(dbaron)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/290b06120a69
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Depends on: 1055702
Depends on: 1130400
You need to log in before you can comment on or make changes to this bug.