1033055 - Make WMFReader decode non-blocking

Status: RESOLVED WONTFIX

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: WIP Patch

Now that bug 979104 has landed, WMFReader's decoding could be made asynchronous.

Attached is the WIP patch to make WMFReader decode async that I tested bug 979104 with. I don't think it's worth spending time landing this, as we'll deprecate the WMFReader when we move to the MP4Reader, but it may be useful for others to look at the patch and see how to make MediaDecoderReaders asynchronous.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: WIP path rebased

Based on top of patch in Bug 1047180.

https://tbpl.mozilla.org/?tree=Try&rev=5c9761c6b8fd

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Windows 7 32-bit try opt test mochitest-1 on 2014-08-12 22:40:38 PDT for push 5c9761c6b8fd
https://tbpl.mozilla.org/php/getParsedLog.php?id=45819952&tree=Try

2150 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_bug465498.html | Test timed out.
2168 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_bug495145.html | Test timed out.
2221 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_bug495300.html | Test timed out.
2240 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_bug686942.html | Test timed out.

WINNT 6.2 try opt test mochitest-1 on 2014-08-12 22:50:59 PDT for push 5c9761c6b8fd
2152 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_bug465498.html | Test timed out.
2170 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_bug495145.html | Test timed out.
TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_bug495300.html | application terminated with exit code 3221225477
PROCESS-CRASH | /tests/content/media/test/test_bug495300.html | application crashed [@ mozilla::MediaDecoderStateMachine::DropVideoUpToSeekTarget(mozilla::VideoData *)]
Return code: 1

23:11:09  WARNING -  PROCESS-CRASH | /tests/content/media/test/test_bug495300.html | application crashed [@ mozilla::MediaDecoderStateMachine::DropVideoUpToSeekTarget(mozilla::VideoData *)]
23:11:09     INFO -  Crash dump filename: c:\users\cltbld~1.t-w\appdata\local\temp\tmp4mhb9g.mozrunner\minidumps\efddadb9-bd18-49ce-9a84-14e1ba05bfb3.dmp
23:11:09     INFO -  Operating system: Windows NT
23:11:09     INFO -                    6.2.9200
23:11:09     INFO -  CPU: x86
23:11:09     INFO -       GenuineIntel family 6 model 30 stepping 5
23:11:09     INFO -       8 CPUs
23:11:09     INFO -  Crash reason:  EXCEPTION_ACCESS_VIOLATION_READ
23:11:09     INFO -  Crash address: 0x44
23:11:09     INFO -  Thread 68 (crashed)
23:11:09     INFO -   0  xul.dll!mozilla::MediaDecoderStateMachine::DropVideoUpToSeekTarget(mozilla::VideoData *) [MediaDecoderStateMachine.cpp:5c9761c6b8fd : 2706 + 0x0]
23:11:09     INFO -      eip = 0x72fb5796   esp = 0x06edfbd4   ebp = 0x06edfbe4   ebx = 0x00000000
23:11:09     INFO -      esi = 0x00000000   edi = 0x00000000   eax = 0x00000000   ecx = 0x08e87000
23:11:09     INFO -      edx = 0x00000002   efl = 0x00010202
23:11:09     INFO -      Found by: given as instruction pointer in context
23:11:09     INFO -   1  xul.dll!mozilla::MediaDecoderStateMachine::OnVideoDecoded(mozilla::VideoData *) [MediaDecoderStateMachine.cpp:5c9761c6b8fd : 959 + 0x6]
23:11:09     INFO -      eip = 0x72fbfb81   esp = 0x06edfbec   ebp = 0x06edfc28
23:11:09     INFO -      Found by: call frame info
23:11:09     INFO -   2  xul.dll!mozilla::MediaDataDecodedListener<mozilla::MediaDecoderStateMachine>::DeliverVideoTask::Run() [MediaDataDecodedListener.h:5c9761c6b8fd : 137 + 0x12]
23:11:09     INFO -      eip = 0x72fbff44   esp = 0x06edfc30   ebp = 0x06edfc34
23:11:09     INFO -      Found by: call frame info
23:11:09     INFO -   3  xul.dll!mozilla::MediaTaskQueue::Runner::Run() [MediaTaskQueue.cpp:5c9761c6b8fd : 194 + 0x9]
23:11:09     INFO -      eip = 0x72fb491e   esp = 0x06edfc3c   ebp = 0x06edfc5c
23:11:09     INFO -      Found by: call frame info
23:11:09     INFO -   4  xul.dll!nsThreadPool::Run() [nsThreadPool.cpp:5c9761c6b8fd : 220 + 0x5]
23:11:09     INFO -      eip = 0x724c140f   esp = 0x06edfc64   ebp = 0x06edfc88
23:11:09     INFO -      Found by: call frame info
23:11:09     INFO -   5  xul.dll!nsThread::ProcessNextEvent(bool,bool *) [nsThread.cpp:5c9761c6b8fd : 770 + 0x5]
23:11:09     INFO -      eip = 0x724c231f   esp = 0x06edfc90   ebp = 0x06edfce0
23:11:09     INFO -      Found by: call frame info
23:11:09     INFO -   6  xul.dll!NS_ProcessNextEvent(nsIThread *,bool) [nsThreadUtils.cpp:5c9761c6b8fd : 265 + 0xc]
23:11:09     INFO -      eip = 0x724d25af   esp = 0x06edfce8   ebp = 0x06edfcf4
23:11:09     INFO -      Found by: call frame info
23:11:09     INFO -   7  xul.dll!mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate *) [MessagePump.cpp:5c9761c6b8fd : 355 + 0x9]
23:11:09     INFO -      eip = 0x7263fca5   esp = 0x06edfcfc   ebp = 0x06edfd24
23:11:09     INFO -      Found by: call frame info
23:11:09     INFO -   8  xul.dll!MessageLoop::RunHandler() [message_loop.cc:5c9761c6b8fd : 222 + 0x8]
23:11:09     INFO -      eip = 0x726333ff   esp = 0x06edfd2c   ebp = 0x06edfd5c
23:11:09     INFO -      Found by: call frame info
23:11:09     INFO -   9  xul.dll!MessageLoop::Run() [message_loop.cc:5c9761c6b8fd : 196 + 0x6]

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

WMFReader is going away.