1033070 - Instrument cert.py and harness.py with more logging and error-checking

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Certification Suite, defect)

Description

[Jonathan Griffin (:jgriffin)]

Since we need to run the cert suite on arbitrary devices with unknown capabilities, we should be very careful to check any operation which can fail or timeout, and log appropriately.

The first candidates for this should probably be harness.py and cert.py here:

https://github.com/mozilla-b2g/fxos-certsuite/tree/master/certsuite

Comment 1

[Armen [:armenzg]]

Look at this now.

Comment 2

[Armen [:armenzg]]

Attachment: Instrumentation of cert.py and harness.py

Comment 3

[Armen [:armenzg]]

dminor, would you have time to have a look at this? https://critic.hoppipolla.co.uk/r/2118

No rush.

Comment 4

[Armen [:armenzg]]

Nvm. I have to change the patch.

Comment 5

[Dan Minor [:dminor]]

Armen, let me know when you're ready and I'll be happy to have a look.

Comment 6

[Armen [:armenzg]]

Thanks Dan!

I have requested a pull request:
https://critic.hoppipolla.co.uk/r/2119

FYI, the patch looks amazing on critic compare to the patch on bugzilla.

Comment 7

[Armen [:armenzg]]

Attachment: Instrumentation of cert.py and harness.py

This patch can also be seen in critic:
https://critic.hoppipolla.co.uk/r/2119

I have done a quick run and it seems to work.

Comment 8

[Armen [:armenzg]]

Do you prefer the review request here? or critic?
Either way works for me.

Comment 9

[Armen [:armenzg]]

Attachment: Instrumentation of cert.py and harness.py

Minor minor changes.

Comment 10

[Dan Minor [:dminor]]

Armen, looks like ato did a thorough review of this. I had a quick look as well, your changes make sense to me.

Comment 11

[Armen [:armenzg]]

Merged! https://github.com/mozilla-b2g/fxos-certsuite/pull/160