Closed Bug 1033100 Opened 6 years ago Closed 6 years ago

codegen for events that have an init dictionary member which is a sequence of a non-null interface type fails to compile

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: heycam, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

I just tried using the event codegen for CSSFontFaceLoadEvent in bug 1028497, where the init dictionary has a member with a sequence type and a default value of [], and I got this error:

 0:12.57 /z/moz2/c/obj/dom/bindings/CSSFontFaceLoadEvent.cpp: In static member function ‘static already_AddRefed<mozilla::dom::CSSFontFaceLoadEvent> mozilla::dom::CSSFontFaceLoadEvent::Constructor(mozilla::dom::EventTarget*, const nsAString_internal&, const mozilla::dom::CSSFontFaceLoadEventInit&)’:
 0:12.57 /z/moz2/c/obj/dom/bindings/CSSFontFaceLoadEvent.cpp:69:17: error: no match for ‘operator=’ (operand types are ‘nsTArray<nsRefPtr<mozilla::dom::FontFace> >’ and ‘const mozilla::dom::Sequence<mozilla::dom::OwningNonNull<mozilla::dom::FontFace> >’)
 0:12.57    e->mFontfaces = aEventInitDict.mFontfaces;
 0:12.57                  ^
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Summary: codegen for events that have an init dictionary member with [] as the default value fails to compile → codegen for events that have an init dictionary member which is a sequence of a non-null interface type fails to compile
Whiteboard: [need review]
Attachment #8449142 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2edcecd4f926
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla33
https://hg.mozilla.org/mozilla-central/rev/2edcecd4f926
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.