1033100 - codegen for events that have an init dictionary member which is a sequence of a non-null interface type fails to compile

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Cameron McCormack (:heycam)]

I just tried using the event codegen for CSSFontFaceLoadEvent in bug 1028497, where the init dictionary has a member with a sequence type and a default value of [], and I got this error:

 0:12.57 /z/moz2/c/obj/dom/bindings/CSSFontFaceLoadEvent.cpp: In static member function ‘static already_AddRefed<mozilla::dom::CSSFontFaceLoadEvent> mozilla::dom::CSSFontFaceLoadEvent::Constructor(mozilla::dom::EventTarget*, const nsAString_internal&, const mozilla::dom::CSSFontFaceLoadEventInit&)’:
 0:12.57 /z/moz2/c/obj/dom/bindings/CSSFontFaceLoadEvent.cpp:69:17: error: no match for ‘operator=’ (operand types are ‘nsTArray<nsRefPtr<mozilla::dom::FontFace> >’ and ‘const mozilla::dom::Sequence<mozilla::dom::OwningNonNull<mozilla::dom::FontFace> >’)
 0:12.57    e->mFontfaces = aEventInitDict.mFontfaces;
 0:12.57                  ^

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix event codegen to compile when an event has a sequence-of-non-null-interface-type member

Comment 2

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2edcecd4f926

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2edcecd4f926