1033103 - Add a function to mozilla::pkix::der for retrieving an entire DER-encoded item, instead of just the value

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: add-ExpectTagAndGetTLV.patch

There are several places where we need (or will be needing soon) to parse a DER sequence and get a SECItem that contains not only the value, but also the tag and length. This patch adds such a function.

*Concrete* suggestions on improving the name are welcome.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8449088 [details] [diff] [review]
add-ExpectTagAndGetTLV.patch

Review of attachment 8449088 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: security/pkix/lib/pkixder.h
@@ +337,5 @@
>    }
>    return input.Skip(length, value);
>  }
>  
> +// Like ExpectTagAndGetTLV, except the output SECItem will contain the encoded

Like ExpectTagAndGetValue?

@@ +340,5 @@
>  
> +// Like ExpectTagAndGetTLV, except the output SECItem will contain the encoded
> +// tag and length along with the value.
> +inline Result
> +ExpectTagAndGetTLV(Input& input, uint8_t tag, /*out*/ SECItem& tlv)

I think the name is fine.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to David Keeler (:keeler) [use needinfo?] from comment #1)
> > +// Like ExpectTagAndGetTLV, except the output SECItem will contain the encoded
> 
> Like ExpectTagAndGetValue?

Fixed. Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd7a8e681c7a

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd7a8e681c7a