1033138 - [RIL] getSmscAddress() causes crash

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Calling getSmscAddress() in Gaia will cause crash, as following log shows:
> 07-02 11:06:37.325 I/Gecko   (  108): ######### Gecko:RadioInterfaceLayer.js:getSmscAddress()
> 07-02 11:06:37.325 I/Gecko   (  108): ######### Gecko:ril_worker.js:getSmscAddress()
> 07-02 11:06:37.335 I/Gecko   (  108): ######### Gecko:RadioInterfaceLayer.js:getSmscAddress(), success: "[phone]",145
> 07-02 11:06:37.716 I/Gecko   (  108): ###!!! [Parent][MessageChannel] Error: Channel error: cannot send/recv
> 07-02 11:06:37.716 I/Gecko   (  108): ############ ErrorPage.js
> 07-02 11:06:37.726 I/Gecko   (  108): [Parent 108] WARNING: pipe error (179): Connection reset by peer: file /home/chucklee/work/mozilla/src/mozilla-central/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line 450
> 07-02 11:06:37.726 I/Gecko   (  108): ###!!! [Parent][MessageChannel] Error: Channel error: cannot send/recv
> 07-02 11:06:37.726 I/Gecko   (  108): ###!!! [Parent][MessageChannel] Error: Channel error: cannot send/recv
> ###!!! [Parent][MessageChannel] Error: Channel error: cannot send/recv
> 07-02 11:06:37.766 I/GeckoDump(  108): Crash reporter : Can't fetch app.reportCrashes. Exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://b2g/content/shell.js :: shell_reportCrash :: line 149"  data: no]

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Use AutoSafeJSContext instead of AutJSContext.

JSAutoContext causes crash now, which didn't while the API is landed.
So use JSSafeAutoContext instead.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8449194 [details] [diff] [review]
Use AutoSafeJSContext instead of AutJSContext.

Review of attachment 8449194 [details] [diff] [review]:
-----------------------------------------------------------------

From bug 878533 comment 47, maybe we should use AutoJSAPI instead.

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8449194 [details] [diff] [review]
Use AutoSafeJSContext instead of AutJSContext.

Review of attachment 8449194 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, please use:

AutoJSAPI jsapi;
if (!jsapi.Init(GetOwner())) {
  // failure handling
}

From there, you can use jsapi.cx() to access the JSContext.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Use AutoJSAPI instead of AutJSContext.

Address comment 3.

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try looks good : https://tbpl.mozilla.org/?tree=Try&rev=a44b68d3f546

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/19a0b1bd21b4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/19a0b1bd21b4