Closed
Bug 1033142
Opened 10 years ago
Closed 10 years ago
B2G RIL: add support for mvno type 'gid' in matchMvno() function
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S6 (18july)
People
(Reporter: jessica, Assigned: jessica)
References
Details
(Whiteboard: [p=2])
Attachments
(4 files, 4 obsolete files)
|
62 bytes,
text/x-github-pull-request
|
vicamo
:
review+
|
Details | Review |
|
4.33 KB,
patch
|
jessica
:
review+
|
Details | Diff | Splinter Review |
|
2.36 KB,
patch
|
jessica
:
review+
|
Details | Diff | Splinter Review |
|
2.46 KB,
patch
|
jessica
:
review+
|
Details | Diff | Splinter Review |
EF_GID1 value is used to identify some MVNOs in apn.json [1]. [1] https://github.com/mozilla-b2g/gaia/blob/v1.3/shared/resources/apn.json
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jjong
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Read EF_GID1 and store it in RIL.iccInfoPrivate.gid1.
Attachment #8455198 -
Flags: review?(htsai)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Return true if EF_GID1 starts with the mvno data (case insensitive).
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8455199 -
Flags: review?(htsai)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8455199 -
Attachment description: Part 2: add support for mvno type 'gid' in matchMvno() function, v2. → Part 2: add support for mvno type 'gid' in matchMvno() function, v1.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8455200 -
Flags: review?(htsai)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8455196 [details] [review] B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109 Just adding EF_GID1 to emulator's sim. Vicamo, may I have you review? Thanks.
Attachment #8455196 -
Flags: review?(vyang)
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8455196 [details] [review] B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109 Commented on Github.
Attachment #8455196 -
Flags: review?(vyang)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8455198 [details] [diff] [review] Part 1: read EF_GID1 from (u)sim card, v1. We should read EFgid1 only if it is enabled in SST/UST, will upload a new patch to fix this.
Attachment #8455198 -
Flags: review?(htsai)
|
|
Assignee | |
Comment 8•10 years ago
|
||
Comment on attachment 8455196 [details] [review] B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109 Vicamo, I uploaded a new patch with comments addressed. May I have your review again? Thanks.
Attachment #8455196 -
Flags: review?(vyang)
|
|
Assignee | |
Comment 9•10 years ago
|
||
Hsinyi, may I have your review? Thanks. Changes since v1: - read EFgid1 only if it is enabled in sst/ust.
Attachment #8455198 -
Attachment is obsolete: true
Attachment #8456741 -
Flags: review?(htsai)
|
||
Comment 10•10 years ago
|
||
Comment on attachment 8456741 [details] [diff] [review] Part 1: read EF_GID1 from (u)sim card, v2. Review of attachment 8456741 [details] [diff] [review]: ----------------------------------------------------------------- Ya~
Attachment #8456741 -
Flags: review?(htsai) → review+
|
|
||
Updated•10 years ago
|
Attachment #8455199 -
Flags: review?(htsai) → review+
|
|
||
Comment 11•10 years ago
|
||
Comment on attachment 8455200 [details] [diff] [review] Part 3: test cases for mvno type 'gid' in matchMvno() function, v1. Review of attachment 8455200 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8455200 -
Flags: review?(htsai) → review+
|
|
||
Updated•10 years ago
|
Attachment #8455196 -
Flags: review?(vyang) → review+
|
|
Assignee | |
Comment 12•10 years ago
|
||
Thanks, Vicamo and Hsinyi! checkin-needed for "B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109 (attachment 8455196 [details] [review])" only, this needs to be merged before the test cases patches in gecko. Thanks.
Keywords: checkin-needed
|
|
||
Comment 13•10 years ago
|
||
https://github.com/mozilla-b2g/platform_external_qemu/commit/227354333a185180b85471f2cc6abfb029e44718
Keywords: checkin-needed
|
|
Assignee | |
Comment 14•10 years ago
|
||
Add r=hsinyi
Attachment #8456741 -
Attachment is obsolete: true
Attachment #8457893 -
Flags: review+
|
|
Assignee | |
Comment 15•10 years ago
|
||
Add r=hsinyi
Attachment #8455199 -
Attachment is obsolete: true
Attachment #8457894 -
Flags: review+
|
|
Assignee | |
Comment 16•10 years ago
|
||
Add r=hsinyi
Attachment #8455200 -
Attachment is obsolete: true
Attachment #8457895 -
Flags: review+
|
|
Assignee | |
Comment 17•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=f87c490390f6 try green!
|
|
Assignee | |
Comment 18•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/417695c8bf7e https://hg.mozilla.org/integration/b2g-inbound/rev/6b72a8cb2e98 https://hg.mozilla.org/integration/b2g-inbound/rev/8a76262cd5f0
|
||
Comment 19•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/417695c8bf7e https://hg.mozilla.org/mozilla-central/rev/6b72a8cb2e98 https://hg.mozilla.org/mozilla-central/rev/8a76262cd5f0
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
|
|
||
Updated•10 years ago
|
Blocks: b2g-ril-interface
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [p=2]
You need to log in
before you can comment on or make changes to this bug.
Description
•