Closed Bug 1033142 Opened 11 years ago Closed 11 years ago

B2G RIL: add support for mvno type 'gid' in matchMvno() function

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S6 (18july)

People

(Reporter: jessica, Assigned: jessica)

References

Details

(Whiteboard: [p=2])

Attachments

(4 files, 4 obsolete files)

B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109
62 bytes, text/x-github-pull-request
vicamo
: review+
Details | Review
Part 1: read EF_GID1 from (u)sim card (final)
4.33 KB, patch
jessica
: review+
Details | Diff | Splinter Review
Part 2: add support for mvno type 'gid' in matchMvno() function (final)
2.36 KB, patch
jessica
: review+
Details | Diff | Splinter Review
Part 3: test cases for mvno type 'gid' in matchMvno() function (final)
2.46 KB, patch
jessica
: review+
Details | Diff | Splinter Review
EF_GID1 value is used to identify some MVNOs in apn.json [1]. [1] https://github.com/mozilla-b2g/gaia/blob/v1.3/shared/resources/apn.json
Assignee: nobody → jjong
Read EF_GID1 and store it in RIL.iccInfoPrivate.gid1.
Attachment #8455198 - Flags: review?(htsai)
Return true if EF_GID1 starts with the mvno data (case insensitive).
Attachment #8455199 - Flags: review?(htsai)
Attachment #8455199 - Attachment description: Part 2: add support for mvno type 'gid' in matchMvno() function, v2. → Part 2: add support for mvno type 'gid' in matchMvno() function, v1.
Comment on attachment 8455196 [details] [review] B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109 Just adding EF_GID1 to emulator's sim. Vicamo, may I have you review? Thanks.
Attachment #8455196 - Flags: review?(vyang)
Comment on attachment 8455196 [details] [review] B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109 Commented on Github.
Attachment #8455196 - Flags: review?(vyang)
Comment on attachment 8455198 [details] [diff] [review] Part 1: read EF_GID1 from (u)sim card, v1. We should read EFgid1 only if it is enabled in SST/UST, will upload a new patch to fix this.
Attachment #8455198 - Flags: review?(htsai)
Comment on attachment 8455196 [details] [review] B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109 Vicamo, I uploaded a new patch with comments addressed. May I have your review again? Thanks.
Attachment #8455196 - Flags: review?(vyang)
Hsinyi, may I have your review? Thanks. Changes since v1: - read EFgid1 only if it is enabled in sst/ust.
Attachment #8455198 - Attachment is obsolete: true
Attachment #8456741 - Flags: review?(htsai)
Comment on attachment 8456741 [details] [diff] [review] Part 1: read EF_GID1 from (u)sim card, v2. Review of attachment 8456741 [details] [diff] [review]: ----------------------------------------------------------------- Ya~
Attachment #8456741 - Flags: review?(htsai) → review+
Attachment #8455199 - Flags: review?(htsai) → review+
Comment on attachment 8455200 [details] [diff] [review] Part 3: test cases for mvno type 'gid' in matchMvno() function, v1. Review of attachment 8455200 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8455200 - Flags: review?(htsai) → review+
Attachment #8455196 - Flags: review?(vyang) → review+
Thanks, Vicamo and Hsinyi! checkin-needed for "B2G emulator: add EFgid1 to emulator's sim (external/qemu) PR#109 (attachment 8455196 [details] [review])" only, this needs to be merged before the test cases patches in gecko. Thanks.
Keywords: checkin-needed
Add r=hsinyi
Attachment #8456741 - Attachment is obsolete: true
Attachment #8457893 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/417695c8bf7e https://hg.mozilla.org/mozilla-central/rev/6b72a8cb2e98 https://hg.mozilla.org/mozilla-central/rev/8a76262cd5f0
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
Whiteboard: [p=2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: