Closed Bug 1033159 Opened 5 years ago Closed 5 years ago

Win64 head_update.js | this test can only run on builds with signed binaries

Categories

(Toolkit :: Application Update, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: dmajor, Assigned: bbondy)

References

Details

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=42830508&tree=Date&full=1

Currently we don't sign binaries on Win64 (bug 711210). 

This error didn't show up on my Date merge of June 10: https://tbpl.mozilla.org/?tree=Date&rev=f33b631a2cbd
But it has shown up since the merge of June 24: https://tbpl.mozilla.org/?tree=Date&rev=a2b84c34f2e1

From a quick glance through code, it's not immediately clear why this started failing only recently.
Likely due to other work we are doing to get the maintenance service working on win64 for app update.

Brian, is this something you can fix without it taking time from your openh264 work? If not, I'll take it. Thanks
Flags: needinfo?(netzen)
Are there any changes for the Date branch? From TBPL output? It looks like the failing test is on an x86 build and the x64 builds (Windows 2012 x64) don't run tests.  Is it maybe set to always build x64 and output to the Windows 8 lines?

If this is a failure with x64 builds I can take Robert. It's likely just adding a skip for those tests on x64.
Flags: needinfo?(netzen)
I found the disposable branches wiki and it says the Date branch is for x64 so it must just be setup to build x64 builds and output on the x86 lines on tbpl.mozilla.org.  I'll take this.
Assignee: nobody → netzen
It's a bit messy. Date produces x86 and x64 builds with their tests results both under the "Windows 8" line. You can search "build_url:" in the log to know which is which, but if only one in the pair fails, it's a pretty safe bet that it's x64.

Plus there was also supposed to be another group of machines putting results under the "Windows 2012 x64" line, but they rotted away. Those jobs stay pending forever until a sheriff kills them.

Anyway, bottom line, yes it's an x64 failure :)
Attached patch bug1033159.diffSplinter Review
Haven't tested yet, but I think this is what's needed.
:dmajor, Could I push and immediately backout to Date to see if it fixes the problem?
Flags: needinfo?(dmajor)
Sure.
Flags: needinfo?(dmajor)
Comment on attachment 8449948 [details] [diff] [review]
bug1033159.diff

Verified that it works on Date now.
Once x64 signing is done we can re-enable.
Attachment #8449948 - Flags: review?(robert.strong.bugs)
Comment on attachment 8449948 [details] [diff] [review]
bug1033159.diff

Is there a bug filed for re-enabling the tests after the binaries are signed?
Attachment #8449948 - Flags: review?(robert.strong.bugs) → review+
No but I'll add one when landing
Blocks: 1035562
https://hg.mozilla.org/integration/mozilla-inbound/rev/975da37bd55f
New bug posted to Bug 1035562
Target Milestone: --- → mozilla33
https://hg.mozilla.org/mozilla-central/rev/975da37bd55f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.