Closed Bug 1033188 Opened 10 years ago Closed 10 years ago

Fix Android gcc warnings about implicit declaration of function 'getenv'

Categories

(Core :: Memory Allocator, defect)

Product:
Core
Component:
Memory Allocator
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

include-getenv-declaration.patch
1.67 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
Fix Android gcc warnings by #including <stdlib.h> for getenv() function prototype:

memory/build/replace_malloc.c:82:3 [-Wimplicit-function-declaration] implicit declaration of function 'getenv'
memory/build/replace_malloc.c:82:30 [enabled by default] initialization makes pointer from integer without a cast

Also mark memory/build/ directory as FAIL_ON_WARNINGS because it has no other warnings on any platform:

https://tbpl.mozilla.org/?tree=Try&rev=d09c91932ed4
Attachment #8449212 - Flags: review?(mh+mozilla)
Attachment #8449212 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/91a55429c78b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: