1033207 - [OTA][Data Migration] APN data settings will be changed to default value after update from 1.4 to 2.0

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Hubert Lu[:hlu] <[e-mail]>]

Description:
    APN data settings will be changed to default value after update from 1.4 to 2.0.

Updated from Flame 1.4:20140701160201 to Flame 2.0:20140701160202

Repro Steps:
(1) Flash device to 20140701160201
(2) Change update channel to v2.0
(3) Go to settings/Cellular & Data/SIM 1/Data Settings
(4) Customize the APN setting
(5) Force check for update
(6) Install the update package


Actual:
    APN setting will be changed to default value.

Expected:
    It should keep the configuration 

Environment:
 Gaia      bf5ad311b6a14383924d6a3898c650ffa4525840
 Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/6817b6858ccf
 BuildID   20140701160201
 Version   30.0
 ro.build.version.incremental=109
 ro.build.date=Mon Jun 16 16:51:29 CST 2014

Comment 1

[howie [:howie]]

Hi Arthur, please have a look or reassign, thanks.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/21746

Jose, would you mind take a look at this patch? The root cause is that the custom apn settings get overwritten when applying the apn settings again. In the patch I added a function that only updates the types that are not involved with custom settings.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8456061 [details]
link to https://github.com/mozilla-b2g/gaia/pull/21746

(In reply to Arthur Chen [:arthurcc] from comment #2)
> Created attachment 8456061 [details]
> link to https://github.com/mozilla-b2g/gaia/pull/21746

LGTM. r=me

This is an issue we have from the very beginning, we have been always overwriting the custom APN (if any). :(

I don't see any collateral issue it might appear taking this change. As you know we must be extra careful with adding changes here as it might result in no APNs and no data calls. I'm glad to see you added a test here. Thanks for taking care of it Arthur.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing, jose!

master: 933165ae1719224dfbe6f96b833996252e66705e

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against v2.0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a36e1fe72b3f63e62432c327e873b5fc49396614