create a new Layout css file in the shared directory

RESOLVED FIXED in Firefox OS v2.1

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: arnau, Assigned: paco)

Tracking

unspecified
2.1 S1 (1aug)
x86
Mac OS X

Firefox Tracking Flags

(b2g-v2.1 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We lack of a base css file for creating layout structures
Assignee: nobody → rnowmrch
Created attachment 8459300 [details] [review]
patch in github

Hey guys, I've been thinking we should try to fix all layout issues, providing a better way to build app structures.
This layout component is based on flexbox, and I also include here all needed markup for lists (we should deprecate list BB at some point).
I guess most apps in gaia could take advantage of it (mostly settings).
Please, let me know what you think :)
Attachment #8459300 - Flags: review?(kyee)
Attachment #8459300 - Flags: feedback?(pivanov)
Attachment #8459300 - Flags: feedback?(wilsonpage)
Comment on attachment 8459300 [details] [review]
patch in github

Clearing review and feedback as Paco is proposing a new solution for this patch.
Attachment #8459300 - Flags: review?(kyee)
Attachment #8459300 - Flags: feedback?(wilsonpage)
Attachment #8459300 - Flags: feedback?(pivanov)
(Assignee)

Updated

4 years ago
Assignee: rnowmrch → pacorampas
(Assignee)

Comment 3

4 years ago
Created attachment 8465261 [details] [review]
patch in github
Attachment #8459300 - Attachment is obsolete: true
Attachment #8465261 - Flags: review?(rnowmrch)
Comment on attachment 8465261 [details] [review]
patch in github

Thanks Paco!
Attachment #8465261 - Flags: review?(rnowmrch) → review+
(Assignee)

Comment 5

4 years ago
Merged: 7a8181f456fdd650f6c38a45c4e1a857ce1ec2ae
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-b2g-v2.1: --- → fixed
Target Milestone: --- → 2.1 S1 (1aug)
Hey guys, just stopping by. I noticed that this landed with a bunch of .gaia-* classes. Since we've been landing web components with gaia- names, can we reserve those for web components in the future?

I think that having a gaia-footer and gaia-list web component make sense, and if there is some transition period, it will making grepping the codebase very difficult.

Thanks for the work on this, it looks good. I just wanted to note my concerns.
Hey Kevin, you are right: those .gaia-* are meant to be temporal helpers 'till gaia components become more stable.
Lists BB is a very close structure, and we needed more options to improve consistency in all apps.
We have discussed this in the past, and as we need list elements to be as light as possible, having a web component for it would make it heavier than just a css file.
Your feedback, as always, is more than welcome ;)
Individual list items should absolutely be normal content, but I do foresee us wanting to use a web component for the overall list - I'm sure this will help with things like virtual lists and scrolling performance in the future.

I suppose we should be cautious about how having a .gaia-list selector could interfere with a transition to a <gaia-list> component.
You need to log in before you can comment on or make changes to this bug.