1033234 - [Vixen] Build breaks when building Vixen tablet project

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

In file included from ../../../gecko/dom/bluetooth/bluedroid/BluetoothA2dpManager.cpp:10:0:
../../../gecko/dom/bluetooth/bluedroid/BluetoothInterface.h:30:3: error: a class-key must be used when declaring a friend
../../../gecko/dom/bluetooth/bluedroid/BluetoothInterface.h:30:3: error: friend declaration does not name a class or function
../../../gecko/dom/bluetooth/bluedroid/BluetoothInterface.h:57:3: error: a class-key must be used when declaring a friend
../../../gecko/dom/bluetooth/bluedroid/BluetoothInterface.h:57:3: error: friend declaration does not name a class or function
../../../gecko/dom/bluetooth/bluedroid/BluetoothInterface.h:119:3: error: a class-key must be used when declaring a friend
../../../gecko/dom/bluetooth/bluedroid/BluetoothInterface.h:119:3: error: friend declaration does not name a class or function

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Vixen is based on JB 4.2. I guess this error might be related to g++ rejects 'friend BluetoothInterface' but only accepts friend class BluetoothInterface'.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I'll watch out for this problem in future patches.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug-1033234.patch

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> I'll watch out for this problem in future patches.

Oh, ok, now i see your comment, you want to fix in the future patches? Ok.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Shawn,

Please land this patch. I meant that I'll watch out for this problem when I send patches in the future.

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1033234 - Fix build break when building JB 4.2, r=tzimmermann

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

 https://tbpl.mozilla.org/?tree=Try&rev=00930cd4a396

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://tbpl.mozilla.org/?tree=Try&rev=d81322cedd23

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d0bc1b814b89

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0bc1b814b89