Remove the settings permission from the manifest

RESOLVED FIXED

Status

Firefox OS
Gaia::Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Now that languagechange has landed in bug 889335, I don't think the settings permission is needed anymore for this app.
Created attachment 8449285 [details] [diff] [review]
bug1033255.patch
Assignee: nobody → 21
Attachment #8449285 - Flags: review?(dale)
Comment on attachment 8449285 [details] [diff] [review]
bug1033255.patch

Review of attachment 8449285 [details] [diff] [review]:
-----------------------------------------------------------------

Gonna pass this along to diego, not familiar with the video app these days
Attachment #8449285 - Flags: review?(dale) → review?(dwilson)

Updated

3 years ago
Attachment #8449285 - Flags: review?(dwilson) → review?(johu)
Comment on attachment 8449285 [details] [diff] [review]
bug1033255.patch

Review of attachment 8449285 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this patch.
Attachment #8449285 - Flags: review?(johu) → review+
This bug depends on bug 1013929.
Depends on: 1013929
https://github.com/mozilla-b2g/gaia/commit/eba7d2db754be6253bcd2f5e2868dc6a8874a8ff
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.