1033257 - Remove the settings permission from the manifest

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Now that languagechange has landed in bug 889335, I don't think the settings permission is needed anymore for this app.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug1033257.patch

Comment 2

[Dale Harvey (:daleharvey)]

Comment on attachment 8449287 [details] [diff] [review]
bug1033257.patch

Review of attachment 8449287 [details] [diff] [review]:
-----------------------------------------------------------------

same

Comment 3

[Diego Wilson [:diego]]

Comment on attachment 8449287 [details] [diff] [review]
bug1033257.patch

This is not in my neck of the woods. Wrong r?

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

I think Punam is the correct person to review this patch. And this bug depends on the patch of bug 1013929.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8449287 [details] [diff] [review]
bug1033257.patch

Punam,

I got the same one in Video app.

One of the reason to request settings is to let mozL10n know the current language. But after the landings of bug 889335 and bug 1013929, mozL10n no long reads language info from settings. That's the main reason to remove it. We may need to check if we use mozSettings for other things.

Comment 6

[Punam Dahiya [:pdahiya]]

Comment on attachment 8449287 [details] [diff] [review]
bug1033257.patch

Investigated and for gallery app, shared/js/l10n.js was the only place using mozSettings. With that dependency removed, its safe to remove the settings permissions from manifest.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/6a04aca51ef11aea9d58c3d52a3972462aafedfd