Remove the settings permission from the manifest

RESOLVED FIXED

Status

Firefox OS
Gaia::Gallery
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Now that languagechange has landed in bug 889335, I don't think the settings permission is needed anymore for this app.
Created attachment 8449287 [details] [diff] [review]
bug1033257.patch
Assignee: nobody → 21
Attachment #8449287 - Flags: review?(dale)
Comment on attachment 8449287 [details] [diff] [review]
bug1033257.patch

Review of attachment 8449287 [details] [diff] [review]:
-----------------------------------------------------------------

same
Attachment #8449287 - Flags: review?(dale) → review?(dwilson)
Comment on attachment 8449287 [details] [diff] [review]
bug1033257.patch

This is not in my neck of the woods. Wrong r?
Attachment #8449287 - Flags: review?(dwilson)

Updated

4 years ago
Flags: needinfo?(johu)
I think Punam is the correct person to review this patch. And this bug depends on the patch of bug 1013929.
Depends on: 1013929
Flags: needinfo?(johu)
Comment on attachment 8449287 [details] [diff] [review]
bug1033257.patch

Punam,

I got the same one in Video app.

One of the reason to request settings is to let mozL10n know the current language. But after the landings of bug 889335 and bug 1013929, mozL10n no long reads language info from settings. That's the main reason to remove it. We may need to check if we use mozSettings for other things.
Attachment #8449287 - Flags: review?(pdahiya)
Comment on attachment 8449287 [details] [diff] [review]
bug1033257.patch

Investigated and for gallery app, shared/js/l10n.js was the only place using mozSettings. With that dependency removed, its safe to remove the settings permissions from manifest.
Attachment #8449287 - Flags: review?(pdahiya) → review+
You need to log in before you can comment on or make changes to this bug.