1033260 - [Messages] Contact suggestion list didn't dismiss when focus on subject(for all branches) and message input field(1.3t only)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Steve Chung [:steveck]]

Discovered this issue while solving the subjuect issue in Bug 1030160.

STR:

1. Open SMS app;
2. Go to the new message composer;
3. Click on the recipient field, and type some words to trigger the suggestion contact list
4. Go to the message composer options and select 'Add Subject';

Expected result:
Recipient should be wrapped up and suggestion contact list is cleared

Actual result:
Recipient isn't wrapped and suggestion contact list is still displayed. The worst-case scenario is long suggestion list covered the entire subject field.

I nominated for 1.3t because situation become worse on it. The suggestion contact still displayed even we focus on message input field, and the list i always there even user select contact and added in recipients field.

Comment 1

[Steve Chung [:steveck]]

Attachment: subject covered by contact list

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Steve Chung [:steveck] from comment #0)
> I nominated for 1.3t because situation become worse on it. The suggestion
> contact still displayed even we focus on message input field, and the list i
> always there even user select contact and added in recipients field.

1.3T+ for this regression

Comment 3

[Steve Chung [:steveck]]

Attachment: Link to github(for v1.3)

Patch for v1.3. The only difference is in unit test.

Comment 4

[Steve Chung [:steveck]]

Attachment: Link to github

This patch if for master.

Comment 5

[Julien Wajsberg [:julienw]]

> The suggestion contact still displayed even we focus on message input field, and the list
> i always there even user select contact and added in recipients field.

In my test, the list disappeared once I selected a contact from the list (after toggling the subject).

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8450745 [details] [review]
Link to github(for v1.3)

I'll review this one once we'll be ready for master.

I think we'll want the v1.3t patch for v1.4 too.

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 8450762 [details] [review]
Link to github

Added sall comments on github, for the unit tests only.

Let's do another round !

Comment 8

[Steve Chung [:steveck]]

Comment on attachment 8450762 [details] [review]
Link to github

Hi Julien, I added some fixing per your suggestion, but I still keep the mock contact list and assertion for the contact list clean up because it shiuld be part of assimilation. Please tell me if you perfer other way for assertion this part , thanks.

Comment 9

[Julien Wajsberg [:julienw]]

Attachment: github PR with follow-ups

Hey Oleg,

I slightly updated Steve's patch, could you please have a look while he's away?

Comment 10

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8451654 [details] [review]
github PR with follow-ups

Looks good, r=me.

Thanks!

Comment 11

[Julien Wajsberg [:julienw]]

master: 39b45bf77b6ea44f7576a986b4ae1035114cb746

Comment 12

[Julien Wajsberg [:julienw]]

Comment on attachment 8451654 [details] [review]
github PR with follow-ups

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): probably when we implemented subject (bug 919966)
[User impact] if declined: the contact suggestions element is not hidden when the user taps the subject (it is when the user taps the message input)
[Testing completed]: yes, both on device and as unit tests
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none

Comment 13

[Julien Wajsberg [:julienw]]

Hey Steve,

I'm not sure you'll be able to see this NI, but I'm trying ;)

Oleg and I can't reproduce the specific 1.3t issue. The issue fixed on master is IMO not big enough to warrant a 1.3t+ blocking status.

Can you please share a more complete STR with us? I really tried hard reproducing on my Tarako but I couldn't...

> The suggestion contact still displayed even we focus on message input field,
> and the list is always there even user select contact and added in recipients field.

=> I couldn't reproduce either of these.

Thanks !

Comment 14

[Julien Wajsberg [:julienw]]

QA, could you please help finding a STR for 1.3t that would show what Steve is saying in comment 0? Thanks

Comment 15

[bhavana bajaj [:bajaj]]

Comment on attachment 8451654 [details] [review]
github PR with follow-ups

approving given this is a low risk fix.

Comment 16

[Julien Wajsberg [:julienw]]

v2.0: 2efe16cd6e61c3eb10e5831ec8298a25b02663f8

Comment 17

[Jason Smith [:jsmith]]

(In reply to Julien Wajsberg [:julienw] from comment #14)
> QA, could you please help finding a STR for 1.3t that would show what Steve
> is saying in comment 0? Thanks

QA is no longer committed to supporting Tarako, so clearing the flag. A partner must indicate the issue is a partner-facing blocker for the patch to be taken to 1.3T.

Comment 18

[Steve Chung [:steveck]]

(In reply to Julien Wajsberg [:julienw] (PTO Monday 14th July) from comment #13)
> Hey Steve,
> 
> I'm not sure you'll be able to see this NI, but I'm trying ;)
> 
> Oleg and I can't reproduce the specific 1.3t issue. The issue fixed on
> master is IMO not big enough to warrant a 1.3t+ blocking status.
> 
> Can you please share a more complete STR with us? I really tried hard
> reproducing on my Tarako but I couldn't...
> 
> > The suggestion contact still displayed even we focus on message input field,
> > and the list is always there even user select contact and added in recipients field.
> 
> => I couldn't reproduce either of these.
> 
> Thanks !

That's weird because I could not reproduce on the latest build either... Sorry for any inconvenience  :-/

Comment 19

[Shally Li（leave from Mozilla）]

This issue has been successfully verified on Flame v2.1&2.0.
See attachment: verified_v2.1.mp4.
Reproduce rate: 0/5

STR:
1. Open Messages app.
2. New a message.
3. Click on the recipient field and type some words or numbers to trigger the suggestion contact list.
4. Tap on textbox to edit message content.
**Recipient is wrapped up and suggestion contact list is cleared.

5. Delete recipient,and repeat step 3.
6. Tap menu and "Cancel" button.
**Suggestion contact list is showing.
7. Then tap Menu->"Add subject" button.
**Recipient is wrapped up and suggestion contact list is cleared.

8. Repeat step 2&3.
9. Tap Menu->Select "Add subject" button.
**Recipient is wrapped up and suggestion contact list is cleared.

Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/ff1100ba2ab8
Build-ID        20141204000228
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141204.040425
FW-Date         Thu Dec  4 04:04:36 EST 2014
Bootloader      L1TC00011880

Flame 2.1 build:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141204.034958
FW-Date         Thu Dec  4 03:50:09 EST 2014
Bootloader      L1TC00011880

Comment 20

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1.MP4