Closed Bug 1033326 Opened 6 years ago Closed 6 years ago

[meta] Support switching cameras without renegotiation

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla34
feature-b2g 2.1
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Keywords: meta, Whiteboard: [2.1-feature-qa+])

Switching cameras without renegotiation is an important usecase for mobile (and useful in a few other cases as well).  For a good user experience, it should be done without renegotiating, which would delay executing the action.

The basic plan is to implement the new Track-oriented APIs from the W3 spec, in particular RTPSender and RTPReceiver, and the track-replace operation.
No longer depends on: 1032840
Related bug (which would provide an alternate way to implement this) is bug 1017990
feature-b2g: --- → 2.1
For info this is tracked for 2.1 release as a platform capability which will enable a feature on the Loop application allowing a user to swap between front and back cameras when in call.

User story to be delivered on the Loop application for FFOS product tracking (will be in a separate bug addressed as part of the Loop application):
As a Loop user on a Loop call I can swap between front and back cameras so that I select the most suited camera for what I am trying to show.
QA Whiteboard: [2.1-feature-qa+]
Flags: in-moztrap?(drno)
QA Contact: drno
QA Whiteboard: [2.1-feature-qa+]
Whiteboard: [2.1-feature-qa+]
Hi, Shell. Are you actively looking at this bug? Are we still targeting to land this bug and its dependencies in FxOS 2.1? The feature landing date is next Tuesday. 

Thank you.
Flags: needinfo?(sescalante)
Hi Kevin,

I'm asking JIB - since it looks like the 2nd of 2 of the breakdown bugs he did for this [meta] just got r+ (the first landed a while ago).  So the question to JIB is when will 1032829 land in FxOS 2.1 and is that everything we needed to get the camera switching?
Flags: needinfo?(jib)
Flags: needinfo?(sescalante)
(In reply to sescalante from comment #4)
> Hi Kevin,
> 
> I'm asking JIB - since it looks like the 2nd of 2 of the breakdown bugs he
> did for this [meta] just got r+ (the first landed a while ago).  So the
> question to JIB is when will 1032829 land in FxOS 2.1 and is that everything
> we needed to get the camera switching?

So the other patches are ready to land on bug 1032829.  The blocker there really should be here - need to support track.stop() because b2g (android?) can't have two cameras open at once.  I plan to land 1032829 today; roc and I talked about the track.stop() issue and we think we have an easy answer; I'll circle with roc when he gets in later today to get it up for review. I can switch cameras on desktop
Flags: needinfo?(jib)
Hi, Shell, are you the best one to own this meta bug? 
And, this one is marked as feature-b2g:2.1 but this is a meta bug, does it mean that bug 1032839 is required and targeted to be landed in 2.1? 

Thank you.
Flags: needinfo?(sescalante)
(In reply to Kevin Hu [:khu] from comment #6)
> Hi, Shell, are you the best one to own this meta bug? 
> And, this one is marked as feature-b2g:2.1 but this is a meta bug, does it
> mean that bug 1032839 is required and targeted to be landed in 2.1? 
> 
> Thank you.

Yes, that's correct.  I'm making Randell the owner of this because he is completing the work on Bug 1032839 such that it will work on B2G.  The feature (which is a platform feature) already works on Desktop, but based on our testing we found that B2G doesn't currently support 2 cameras being active at the same time.  So we have to add some extra code to work around that.  I expect the remaining code to be finished, tested and landed within the next day.
Assignee: nobody → rjesup
Flags: needinfo?(sescalante)
Feature has landed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [needs-verification]
This requires knowledge of how the WebRTC APIs work. Marking this as [QAnalyst-verify-]
QA Whiteboard: [needs-verification] → [QAnalyst-verify-][needs-verification]
Edward, can we please get someone to verify this?
Flags: needinfo?(edchen)
[Environment]
Gaia      2a612867039a7cfb3af6e692bfae4482b06705e9
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/004bc0d262e5
BuildID   20140919000204
Version   34.0a2
ro.build.date   Fri Jun 27 15:57:58 CST 2014
ro.bootloader   L1TC00011230
ro.build.version.incremental   110


[Loop client]
https://github.com/mozilla-b2g/firefoxos-loop-client
Version: c8eb6e8

[Require]
As a Loop user on a Loop call I can swap between front and back cameras so that I select the most suited camera for what I am trying to show.

[Result]
PASS
Status: RESOLVED → VERIFIED
Flags: needinfo?(edchen)
QA Whiteboard: [QAnalyst-verify-][needs-verification] → [QAnalyst-verify-]
QA Whiteboard: [QAnalyst-verify-] → [QAnalyst-Triage+]
Flags: in-moztrap?(drno)
You need to log in before you can comment on or make changes to this bug.