Closed
Bug 1033391
Opened 10 years ago
Closed 10 years ago
Enable GeometryUtils APIs in privileged code
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: miker, Assigned: miker)
Details
Attachments
(1 file, 1 obsolete file)
3.60 KB,
patch
|
roc
:
review+
smaug
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
devtools has code relying on this in Aurora already.
Assignee | ||
Comment 1•10 years ago
|
||
roc: Feel free to delegate but I had to choose somebody. Do you really have 52 reviews in your queue? When this lands we need to uplift to Aurora and Beta.
Attachment #8449475 -
Flags: review?(roc)
Comment on attachment 8449475 [details] [diff] [review] Enable getBoxQuads in priviliged code Review of attachment 8449475 [details] [diff] [review]: ----------------------------------------------------------------- Seems to me this will disable use of getBoxQuads from content --- we require the pref to be set *and* only chrome can use it. That's not what we want. Checking the pref for Web content but ignore the pref when in chrome sounds good to me, though.
Attachment #8449475 -
Flags: review?(roc) → review-
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8449475 -
Attachment is obsolete: true
Attachment #8450163 -
Flags: review?(roc)
Attachment #8450163 -
Flags: review?(roc) → review+
Comment 4•10 years ago
|
||
This or one of the other alternatives needs to land on aurora before it merges to beta on July 21st, or not only will the dozens of tests I know will be permaorange will be permaorange, but I presume also the feature they test will be broken.
tracking-firefox32:
--- → ?
Assignee | ||
Comment 5•10 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=894d786a7d97
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8450163 [details] [diff] [review] Enable getBoxQuads in priviliged code "Changes to WebIDL files in this repo require review from a DOM peer in the form of r=..." Asking smaug for additional review.
Attachment #8450163 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8450163 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8450163 [details] [diff] [review] Enable getBoxQuads in priviliged code Approval Request Comment [Feature/regressing bug #]: Box Model Highlighter [User impact if declined]: The entire feature will be broken [Describe test coverage new/current, TBPL]: Without this patch hundreds of tests will be failing. With it we should have a green tree. [Risks and why]: Low risk, we simply enable a feature for privileged code. [String/UUID change made/needed]: None
Attachment #8450163 -
Flags: approval-mozilla-beta?
Attachment #8450163 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3be3729d084e
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Comment on attachment 8450163 [details] [diff] [review] Enable getBoxQuads in priviliged code Too late for 31 but taking it for 32.
Attachment #8450163 -
Flags: approval-mozilla-beta?
Attachment #8450163 -
Flags: approval-mozilla-beta-
Attachment #8450163 -
Flags: approval-mozilla-aurora?
Attachment #8450163 -
Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/3be3729d084e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Comment 11•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/9234fae30e38
status-firefox32:
--- → fixed
status-firefox33:
--- → fixed
Updated•10 years ago
|
status-firefox31:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•