1033391 - Enable GeometryUtils APIs in privileged code

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

devtools has code relying on this in Aurora already.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Enable getBoxQuads in priviliged code

roc: Feel free to delegate but I had to choose somebody.

Do you really have 52 reviews in your queue?

When this lands we need to uplift to Aurora and Beta.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8449475 [details] [diff] [review]
Enable getBoxQuads in priviliged code

Review of attachment 8449475 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to me this will disable use of getBoxQuads from content --- we require the pref to be set *and* only chrome can use it. That's not what we want.

Checking the pref for Web content but ignore the pref when in chrome sounds good to me, though.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Enable getBoxQuads in priviliged code

Comment 4

[Phil Ringnalda (:philor)]

This or one of the other alternatives needs to land on aurora before it merges to beta on July 21st, or not only will the dozens of tests I know will be permaorange will be permaorange, but I presume also the feature they test will be broken.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Try:
https://tbpl.mozilla.org/?tree=Try&rev=894d786a7d97

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8450163 [details] [diff] [review]
Enable getBoxQuads in priviliged code

"Changes to WebIDL files in this repo require review from a DOM peer in the form of r=..."

Asking smaug for additional review.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8450163 [details] [diff] [review]
Enable getBoxQuads in priviliged code

Approval Request Comment
[Feature/regressing bug #]: Box Model Highlighter
[User impact if declined]: The entire feature will be broken
[Describe test coverage new/current, TBPL]: Without this patch hundreds of tests will be failing. With it we should have a green tree.
[Risks and why]: Low risk, we simply enable a feature for privileged code.
[String/UUID change made/needed]: None

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3be3729d084e

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8450163 [details] [diff] [review]
Enable getBoxQuads in priviliged code

Too late for 31 but taking it for 32.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3be3729d084e

Comment 11

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9234fae30e38