1033570 - In-content dialogs close-icon too wide with HiDPI

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Richard Marti (:Paenglab)]

The in-content dialog close-icon is to wide with HiDPI.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: close-iconFix.patch

The close-icon button used on in-content dialogs has a button-box in his structure. This patch adds a selector to also fit for the width: 16px.

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 8449651 [details] [diff] [review]
close-iconFix.patch

Review of attachment 8449651 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming you tested it and it fixes the problem, as I didn't. :)

Comment 3

[Carsten Book [:Tomcat]]

Hi,

could you provide a Try link. Suggestions for what to run if you haven't
yet can be found here:
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 4

[Richard Marti (:Paenglab)]

Isn't it to much to let go through the try building for a one line CSS patch?

But I'll start one.

Comment 5

[Richard Marti (:Paenglab)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=b0b6ba3bfd27

Comment 6

[Ryan VanderMeulen [:RyanVM]]

(In reply to Richard Marti (:Paenglab) from comment #4)
> Isn't it to much to let go through the try building for a one line CSS patch?

Indeed. Tomcat, try to use your judgement in such situations :)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/043995106767

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/043995106767