In-content dialogs close-icon too wide with HiDPI

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
mozilla33
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The in-content dialog close-icon is to wide with HiDPI.
(Assignee)

Comment 1

5 years ago
Created attachment 8449651 [details] [diff] [review]
close-iconFix.patch

The close-icon button used on in-content dialogs has a button-box in his structure. This patch adds a selector to also fit for the width: 16px.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8449651 - Flags: review?(dolske)
(Assignee)

Updated

5 years ago
Blocks: 1021618
Comment on attachment 8449651 [details] [diff] [review]
close-iconFix.patch

Review of attachment 8449651 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming you tested it and it fixes the problem, as I didn't. :)
Attachment #8449651 - Flags: review?(dolske) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Hi,

could you provide a Try link. Suggestions for what to run if you haven't
yet can be found here:
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices
Keywords: checkin-needed
(Assignee)

Comment 4

5 years ago
Isn't it to much to let go through the try building for a one line CSS patch?

But I'll start one.
(Assignee)

Comment 5

5 years ago
Try: https://tbpl.mozilla.org/?tree=Try&rev=b0b6ba3bfd27
Keywords: checkin-needed
(In reply to Richard Marti (:Paenglab) from comment #4)
> Isn't it to much to let go through the try building for a one line CSS patch?

Indeed. Tomcat, try to use your judgement in such situations :)
https://hg.mozilla.org/integration/fx-team/rev/043995106767
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/043995106767
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla33
Summary: In-content dialogs close-icon to wide with HiDPI → In-content dialogs close-icon too wide with HiDPI
You need to log in before you can comment on or make changes to this bug.