Closed
Bug 1033623
Opened 10 years ago
Closed 10 years ago
[ui] when filling out a form in alert manager, hitting the X to close the form refreshes the page
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: kaustabh93, Mentored)
References
Details
(Whiteboard: [next_bug][lang=javascript])
This is bad UI and very frustrating. If we cancel an operation in one of the popups (currently, comment, bug, tbplurl, duplicate) then we should not refresh the page.
To see what alert manager does and how to get started, here is a good place to start:
https://wiki.mozilla.org/Auto-tools/Projects/AlertManager
Please ask questions in this bug or on irc!
Reporter | ||
Updated•10 years ago
|
Whiteboard: [lang=javascript] → [good_next_bug][lang=javascript]
Reporter | ||
Updated•10 years ago
|
Summary: when filling out a form in alert manager, hitting the X to close the form refreshes the page → [ui] when filling out a form in alert manager, hitting the X to close the form refreshes the page
Reporter | ||
Updated•10 years ago
|
Whiteboard: [good_next_bug][lang=javascript] → [next_bug][lang=javascript]
Assignee | ||
Comment 1•10 years ago
|
||
I would like to work on this one.
Assignee | ||
Comment 2•10 years ago
|
||
Hi,
For an event of cancellation, instead of reloading the entire page, I am accessing the page from the browser history. I have created a pull request, please review it.
Thank You.
Reporter | ||
Comment 3•10 years ago
|
||
does this reload the page? I would think going back in history would reload a page,but I could be wrong.
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #3)
> does this reload the page? I would think going back in history would reload
> a page,but I could be wrong.
In my local machine, the page isn't being reloaded.
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Kaustabh Datta Choudhury from comment #4)
> (In reply to Joel Maher (:jmaher) from comment #3)
> > does this reload the page? I would think going back in history would reload
> > a page,but I could be wrong.
>
> In my local machine, the page isn't being reloaded.
Instead a cached copy is loaded and hence the refresh time is reduced
Reporter | ||
Comment 6•10 years ago
|
||
I merged this and made it live, it is faster, but I don't like how it refreshes the page. When we add a bug, it submits to the server without refreshing the page. cancelling the popup should make it go away, quite possibly we need a different type of popup or to just hide the div?
Assignee | ||
Comment 7•10 years ago
|
||
Hi,
I have changed this & created a pull request. Please do have a look.
Thanks.
Reporter | ||
Comment 8•10 years ago
|
||
I have deployed all changes for this from github! Thanks for your work and this issue works great.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•10 years ago
|
||
Thanks,
Reporter | ||
Updated•10 years ago
|
QA Contact: kaustabh93
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → kaustabh93
You need to log in
before you can comment on or make changes to this bug.
Description
•