1033628 - [B2G][2.0][l10n][Email]Tamil: Searching email in Tamil causes the window to shift off screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: Search Tamil.png

Description:
When searching in Tamil, the window shifts to the left causing a portion of it to be off screen.  This is caused by the "All" string.  Though this is currently restricted to Tamil, this will seemingly occur with any language that has too long of a string.

Prerequisites:
1) Settings > Language > Tamil (Ta)

Repro Steps:
1) Update a Flame to 20140630000201
2) Open the email app
3) Progress through the steps to add a new email
4) Press the search button
5) Note that the screen shifts.

Actual:
The window shifts to the left, causing a portion to move off the screen.

Expected:
Strings that are too long are truncated instead of shifting the window.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140702000201
Gaia: 3bfe47c58c959c42f5ffe0309b5380ea514ccd69
Gecko: f40e767ea283
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0



Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/12108/
See attached: screenshot

Comment 1

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue does not occur on 1.4 Flame.

Environmental Variables:
Device: Flame 1.4
Build ID: 20140702063007
Gaia: e8599c2b346addf3bf857310502e5b542ae7d0b2
Gecko: 5ff8eb391b65
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Tamil was not an available language.

Comment 2

[James Burke [:jrburke]]

Attachment: GitHub pull request

The text in those search filter li elements were allowed to overflow out of the boxes, causing problems. A CSS change boxes them in. I will attach an image that shows the result of these changes using the "accented english" fake locale.

Comment 3

[James Burke [:jrburke]]

Attachment: search-filter-truncate.png

This screenshot from a flame device shows how it looks with the pull request applied for the accented English fake locale. Note how Subject is truncated.

As the comment in the pull request change mentions, trying to put in ellipsis for these small fields meant that most locales would end up with at least one entry with ellipsis, even the English one, where just truncating allowed the full text to appear in more cases, including English.

I also expect this issue to show up in 2.0, so asking for 2.0? as part of the visual refresh polish. The simple, very targeted CSS change should be safe to uplift.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Does this issue occur on 2.1?

Comment 5

[James Burke [:jrburke]]

It occurs on latest gaia master/nightly flame builds.

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

As James said this does occur on the latest 2.1 Flame.

Environmental Variables:
Device: Flame Master
BuildID: 20140703040209
Gaia: d7a517f0bde32072f1799e4a47ea34c6d786c287
Gecko: b7b20af4a4fb
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

The window shifts of to the left.

Comment 7

[James Burke [:jrburke]]

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/0908f7b16695bebb8129173e7418c2af7854e863

from pull request:
https://github.com/mozilla-b2g/gaia/pull/21309

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/e0b71cf9ae17a9fb7a5b6221385ee69f25bc71ab

Comment 9

[Théo Chevalier]

Verified fixed on Flame 2.0 with Tamil

Gaia      5ba22d458fdb63bd72c59de53c701d0efe35c1e2
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/6fbc60a80c6d
BuildID   20140806000200
Version   32.0
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 10

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame v2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141204.034958
FW-Date         Thu Dec  4 03:50:09 EST 2014
Bootloader      L1TC00011880