Closed Bug 1033677 Opened 11 years ago Closed 11 years ago

automatically go to macro/typedef definitions, like we do for classes/functions

Categories

(Webtools Graveyard :: DXR, defect)

Product:
Webtools Graveyard
Component:
DXR
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: fitzgen, Assigned: nave.mvn)

Details

(Whiteboard: easy)

When you type in a function or class and hit enter, you automatically jump to the definition. When you type in a macro or typedef and hit enter, it does a normal search. Then I have to click on a result. Then I have to click on the macro, open a context menu, and then click jump to definition. This seems like a lot of extra work, and is also not consistent with behavior above.
This will involve additions to query.py:Query.direct_result().
Whiteboard: easy
Assignee: nobody → nave.mvn
Still have some questions on the test cases for this. I have made the relevant comments on the pull request on github
Commits pushed to master at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/dafa73d4565f731e5301f97b67f06738e3abdbb5 Add direct query capability for macros/typedefs. Fixes bug 1033677. https://github.com/mozilla/dxr/commit/657c8c13326f7bf2b203f3319f893fa473dfd7fa Merge direct result support for macros and typedefs. Fix bug 1033677. Close #306.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Commits pushed to es at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/dafa73d4565f731e5301f97b67f06738e3abdbb5 Add direct query capability for macros/typedefs. Fixes bug 1033677. https://github.com/mozilla/dxr/commit/657c8c13326f7bf2b203f3319f893fa473dfd7fa Merge direct result support for macros and typedefs. Fix bug 1033677. Close #306.
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.