Pin TPS to specific versions of mozbase packages

RESOLVED FIXED in Firefox 31

Status

defect
RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Trunk
mozilla33

Firefox Tracking Flags

(firefox31 fixed, firefox32 fixed, firefox33 fixed)

Details

Attachments

(1 attachment)

As we have seen with bug 997244 a lot of regressions in TPS have been generated, because we depend on the latest version of mozbase packages. We should get rid of all of those loose version dependencies and enforce strict versions.
Posted patch Fixed deps v1Splinter Review
This will mark dependencies to modules we directly import as fixed. One question remains through, how should we handle indirect imports? Lets say what happens when mozprofile gets bumped? Usually we should only add dependencies to modules we import on our own to setup.py, but the above could also break us. Andrew, what do you think?
Attachment #8450096 - Flags: review?(ahalberstadt)
Comment on attachment 8450096 [details] [diff] [review]
Fixed deps v1

Review of attachment 8450096 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm. I think if you are worried about indirect imports causing breakage, then we should just add them as explicit dependencies and peg them to the proper version. Though it might not be all that common. Maybe we could add them in the future if they cause us problems? Up to you.
Attachment #8450096 - Flags: review?(ahalberstadt) → review+
That's what I'm thinking, right. So lets go with this patch for now, and do the other dependencies if necessary later. Thanks for the review.
https://hg.mozilla.org/mozilla-central/rev/db81d22fe5ad
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

9 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.