1033703 - Pin TPS to specific versions of mozbase packages

Status: RESOLVED FIXED

(Testing Graveyard :: TPS, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

As we have seen with bug 997244 a lot of regressions in TPS have been generated, because we depend on the latest version of mozbase packages. We should get rid of all of those loose version dependencies and enforce strict versions.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: Fixed deps v1

This will mark dependencies to modules we directly import as fixed. One question remains through, how should we handle indirect imports? Lets say what happens when mozprofile gets bumped? Usually we should only add dependencies to modules we import on our own to setup.py, but the above could also break us. Andrew, what do you think?

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8450096 [details] [diff] [review]
Fixed deps v1

Review of attachment 8450096 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm. I think if you are worried about indirect imports causing breakage, then we should just add them as explicit dependencies and peg them to the proper version. Though it might not be all that common. Maybe we could add them in the future if they cause us problems? Up to you.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

That's what I'm thinking, right. So lets go with this patch for now, and do the other dependencies if necessary later. Thanks for the review.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db81d22fe5ad

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db81d22fe5ad

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e32373a324ae
https://hg.mozilla.org/releases/mozilla-beta/rev/f32f13e55095