1033851 - Add in terms link for when people log in using Firefox Accounts

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[Andy McKay]

If you login using Firefox Accounts, you won't see the custom terms and conditions link that Persona currently has. That means you can get to the payment page without having seen all the correct terms.

The suggested fix to this is to add in a link to the payment terms on the PIN page. 

This bug is to figure out where we add that link in.

Comment 1

[Andy McKay]

Is this just as simple as a link on the PIN page Maureen?

Comment 2

[Maureen Hanratty]

Attachment: Screenshot 2014-07-23 12.19.26.png

Is this the terms on the Persona screen you are talking about? These terms are Persona specific rather than Payments specific. We can put the links on the PIN page but will need to tweak the visual design slightly to make room for the text.

Comment 3

[Maureen Hanratty]

Attachment: Create pin screen with terms & conditions

Comment 4

[Andy McKay]

Yup that's pretty much it from a functional point of view. The terms in persona, actually point to the Marketplace terms. We just need to move the links over to the PIN page so the user gets a chance to see all the relevant payment terms before they actually pay.

Comment 5

[Andy McKay]

Is there anything else you want to do here, should we pass it off to a developer to implement?

Comment 6

[Maureen Hanratty]

We'll want to change the visual design of the pin screen so that we have enough room under the pin entry form to include the terms language and the "Cancel" "Continue" buttons. Phil, what do you think?

Comment 7

[Philip [:pwalm]]

andym and I had a chat about this:

- On the "Create PIN" page, we show a link to the T&C just below the pin input field. When the keyboard pops up, it disappears. T&C should be added to the very bottom of the Marketplace home page (or at least the bottom of the users account page, so it is always accessible.

- On the "Enter PIN" page, we just show the "Forgot PIN?" link under the input field. It stays visible when the keyboard pops up because it is a much shorter string.

Comment 8

[Andy McKay]

The terms link should go to here: https://marketplace.firefox.com/terms-of-use

The privacy policy should go to here: https://marketplace.firefox.com/privacy-policy

Comment 9

[Stuart Colville [:muffinresearch]]

(In reply to Andy McKay [:andym] from comment #8)
> The terms link should go to here:
> https://marketplace.firefox.com/terms-of-use
> 
> The privacy policy should go to here:
> https://marketplace.firefox.com/privacy-policy

I'm assuming you want both links shown under the create-pin page? Like comment 3 (sans the overlap)

Should this be for everything (persona and FxA) or just when using FxA?

Comment 10

[Andy McKay]

(In reply to Stuart Colville [:scolville] [:muffinresearch] from comment #9)
> (In reply to Andy McKay [:andym] from comment #8)
> > The terms link should go to here:
> > https://marketplace.firefox.com/terms-of-use
> > 
> > The privacy policy should go to here:
> > https://marketplace.firefox.com/privacy-policy
> 
> I'm assuming you want both links shown under the create-pin page? Like
> comment 3 (sans the overlap)

Both links, shown as per comment 7, 

> Should this be for everything (persona and FxA) or just when using FxA?

Just FxA. When people log in using Persona, they see them on Persona pages. They won't for FxA.

Comment 11

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/spartacus/pull/115

Comment 12

[Stuart Colville [:muffinresearch]]

So back to the drawing board with this one. Going to need to iframe the terms and privacy policy because links in the trusted UI either take you to the pages with no way back OR with target attrs nothing happens.

Thinking we need something like persona does here: 

https://github.com/mozilla/persona/blob/dev/resources/static/dialog/views/inline_tospp.ejs

Comment 13

[Stuart Colville [:muffinresearch]]

Updated PR is here: https://github.com/mozilla/spartacus/pull/132

Comment 14

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/spartacus/commit/4ff775d785b6b88031eae17e0bb94e8f65e3792b

Comment 15

[Stuart Colville [:muffinresearch]]

To test this - go to a server with FxA turned on and you should see terms under the pin entry form on the create-pin page.

* On a device with the trusted-ui, this should load terms and or privacy in a overlaid iframe (very similar to the way persona does it).
* On a normal device this should open a new window/tab. (Again this follows the same approach used by Persona)

Comment 16

[Victor Carciu]

We are not able to verify this because of https://bugzilla.mozilla.org/show_bug.cgi?id=1053754

Comment 17

[krupa raj[:krupa]]

verified fixed.