1033886 - RottenTomatoes.com doesn't server mobile content to Firefox OS

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Karl Dubost💡 :karlcow]

+++ This bug was initially created as a clone of Bug #950170 +++

With Firefox OS on a Flame device.
Go to http://www.rottentomatoes.com/

Expected: 
Receive the mobile site like Firefox on Android.
aka http://www.rottentomatoes.com/mobile/

Actual:
Receiving the desktop site.

Comment 1

[Hallvord R. M. Steen [:hallvors]]

This site intends to send mobile browsers to a mobile site, but there is a mistake in the code intended to handle the redirect. Hence the browser on Firefox OS phones get desktop content instead of mobile.

There is client-side browser detection in these files:

<script src="http://d1rjibvava1hwe.cloudfront.net/static/js/lib/device.min.js"></script>
<script src="http://d1rjibvava1hwe.cloudfront.net/static/js/mobile.upsell.redirect.js"></script>

Examples of the JavaScript logic:


	/***** START of mobile upsell-redirect flow ******/ 
	if(device.tablet()){
		if(!getParameterByName("nopopup") && !hasSeenUpsell()){
			setCookie(UPSELL_COOKIE, "true", UPSELL_COOKIE_EXPIRE_DAYS, "/");
			showUpsell();		
		}
		// Else continue to desktop page (no-op)	
	}
	else if(device.mobile()){
		if(!getParameterByName("nopopup") && !hasSeenUpsell()){
			setCookie(UPSELL_COOKIE, "true", UPSELL_COOKIE_EXPIRE_DAYS, "/");
			showUpsell();				
		}
		
		if(!getParameterByName("fullsite")){
			if(!hasFullSitePermCookie()){
				redirectToMobileWeb();
			}
			else {
				if(!hasRevertPromptCookie()){
					promptRevertToMobileWeb();
				}
			}
			
		}
	}

In this code, hasSeenUpsell() tries to call getCookie() - this error is thrown:

ReferenceError: getCookie is not defined

No mobile browsers are currently redirected to the mobile site due to the missing function definition.

Comment 2

[Hallvord R. M. Steen [:hallvors]]

The site needs to make sure getCookie() is defined before this code runs.

Comment 3

[Karl Dubost💡 :karlcow]

First Attempt at human contact
http://twitter.com/MozWebCompat/status/492493518967820289
http://www.linkedin.com/in/bestrada

Comment 4

[Karl Dubost💡 :karlcow]

This has been fixed.
Yeah \o/