103393 - areTheSameFileNames does not work correctly on Mac!

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Peter Lubczynski]

In nsPluginHostImpl.cpp, areTheSameFileNames compares leafs names of paths.
However, on Mac, we sometimes pass the full path and sometimes pass just the
leaf name. This should all be converted to using nsIFile. 

Severity: On Macintosh, we may pick up the wrong plugin if there are duplicates.
This is quite serious because the order seems to be scattered. If will cause
multiple plugins of the same kind of be listed in about:plugins

To Reproduce: 
1) Install a bunch of plugins in the System folder and local folder
2) Visit about:plugins. See if there are any duplicates already
3) Visit a Quicktime site
4) Go back to about:plugins, Quicktime may be listed twice

Comment 1

[Peter Lubczynski]

Attachment: workaround patch

Comment 2

[Peter Lubczynski]

The patch will always try to pass the full path. Mac has this set always while
other platforms never do. It's not a perfect solution, but it will do until we
can convert to using nsIFile.

Andrei, can you review?

Comment 3

[Peter Lubczynski]

Attachment: better patch

Comment 4

[Jaime Rodriguez, Jr.]

what are the chances this will make the 094 branch?

Comment 5

[Peter Lubczynski]

Because we can either get the full path or just the leaf filename on Mac, the
new patch will attempt to compare either/or to see if they match. It'll also
work for comparing just two leaf filenames.

Andrei, can you review the new patch?

Comment 6

[av (gone)]

Comment on attachment 52333 [details] [diff] [review]
better patch

r=av, Peter, please add some comments to the code explaining why we do this.

Comment 7

[Peter Lubczynski]

actually I don't think this is an rtm stopper anymore because it should not
altar user experience too much...adding minus

Comment 8

[Marc Attinasi]

Comment on attachment 52333 [details] [diff] [review]
better patch

sr=attinasi

Comment 9

[Peter Lubczynski]

patch checked in, marking FIXED

Comment 10

[Peter Lubczynski]

Talking with Beard, this should be checked in on the 0.9.4 branch. This will
prevent us from screwing up in plugin scanning code on the Mac and possibly
loading the same plugin twice.

Comment 11

[Jaime Rodriguez, Jr.]

PDT-, let's get it into the next release.

Comment 12

[Peter Lubczynski]

Patch already on trunk, marking FIXED, again

Comment 13

[shrirang khanzode]

v

Comment 14

[Jaime Rodriguez, Jr.]

so, this was on the trunk before we branched, right?

Comment 15

[Peter Lubczynski]

This is OLD.