1033970 - Line not complete highlighted when tapping on a participant in a multiparty call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Loli (:lolimartinezcr)]

Tested
Hamachi
2.1
Gecko-c778b21
Gaia-eda2575

Reproducible: 100%

Pre-requisites: Multicall established.

STRs:
1. Tap right arrow.
2. Tap over a call.

Actual result:
All phone number shows background. (see attached image: IMG_0005.jpg)

Expected result:
Only hung up button shows with backgroud, and it should look and feel a button. I need info UX

Comment 1

[Loli (:lolimartinezcr)]

Attachment: IMG_0005.jpg

Comment 2

[Loli (:lolimartinezcr)]

Also in:
Hamachi
2.0
Gecko-6976791
Gaia-8fb5e2a

Comment 3

[Paco Rampas [:paco]]

Attachment: conference-button.png

Comment 4

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 5

[Carrie Wang [New account: [e-mail]]]

ni? Vicky to confirm the "tapped" status of the button here. Thanks!

Comment 6

[Anthony Ricaud (:rik)]

Comment on attachment 8450132 [details]
patch in github

I don't understand the original report so I'm not sure what to review here.
Is this just about highlighting the whole line when taping a number? Please update the title to describe exactly what this bug is about.

Comment 7

[Paco Rampas [:paco]]

Attachment: overflow-text-conferece.png

Comment 8

[Paco Rampas [:paco]]

Comment on attachment 8450130 [details]
conference-button.png

Maria have changed the title, now is more descriptive.

About your comment on github I have changed the padding-right for text overflow. Also, Vicky said to me that the hang out action should be triggered clicking on the all element of the list, not only on the icon area.

Thanks :D

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 8450132 [details]
patch in github

Thanks.

Now that you can merge your patches, don't forget to add "r=rik" in the merge message.

Comment 10

[Paco Rampas [:paco]]

> Now that you can merge your patches, don't forget to add "r=rik" in the
> merge message.

Many thanks :D
I want using my new privilegies to merge, but this patch have errors on travis. The errors aren't caused for my patch. This is the error log:

SUMMARY

-------

passed: 71

failed: 1

todo: 56 (skipped: 3)

FAILED TESTS

-------

test_privileged_app_contacts_prompt.py test_privileged_app_contacts_prompt.TestPrivilegedAppContactsPrompt.test_contact_prompt

I think is better wait for travis green but with the troubles that currently travis have, can I merge? Or what is the procedure to merge with errors?

Many thanks.

Comment 11

[Paco Rampas [:paco]]

I have merged because I have rebased it and the travis was green. Thanks.

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Paco, you forgot merging it ;)

Merged: 416dd915f4d8d0f6d0c1cfe0aee109587bb44400

Comment 13

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.1
Gecko d2e992a
Gaia bbcf53d