1033981 - bzexport is eating the patch comment

Status: RESOLVED DUPLICATE of bug 1033258

(Developer Services :: Mercurial: bzexport, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

This bug has bitten me at least twice now, with the latest appearance being in bug 746622 comment 30. Here is the terminal log:

past@holo:fx-team$ hg bzexport -ei
Refreshing configuration cache for https://bugzilla.mozilla.org/bzapi/
saved edited form in .hg/last_bzexport.txt
Requesting review from [e-mail]
Attach patch (y/n)? y
rdp-changes uploaded as https://bugzilla.mozilla.org/attachment.cgi?id=8450073&action=edit
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=8442695 (rdp-changes) - Properly handle bound functions in event listeners and objects with 'handleEvent' methods v4 (y/n)? y
past@holo:fx-team$ 


And here is the message from my editor, as I always copy the entire message before saving:


Bug: 746622

Attachment Filename: rdp-changes
Attachment Description: Properly handle bound functions in event listeners and objects with 'handleEvent' methods v5
Reviewers: [e-mail]
Feedback: <none>
Attachment Comment (appears as a regular comment on the bug):

This fixes the regression from bug 991797, by making the failure to fetch a definition site non-fatal again. I discovered at least another case of a similar regression from that bug that I will file a followup for. Writing a test for catching that sort of bug is still pending on the investigation in bug 942899.

---- END Attachment Comment ----

Comment 1

[Ed Morley [:emorley]]

Caused by ted's switch to the new bzapi compatibility layer, update to version-control-tools repo tip until bug 1033258 and deps pushed to prod.