1034079 - There's no hover effect on the "resume" button in the Debugger's toolbar

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

While the debugger is paused, the resume button is colored differently but has no background hover effect. It should, because just like the other buttons, it's clickable.

Sounds like a regression from the toolbars thinification or design flattening?

Comment 1

[Brian Grinstead [:bgrins]]

This is an issue even on stable (30) before any of the latest changes, but I agree that it should have a different background on hover.  Before the flattening it was more obviously 'active' so the the lack of a hover effect was less noticeable.

Comment 2

[Brian Grinstead [:bgrins]]

I'll update this

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: debugger-resume-button.patch

There are a couple of options here.  The resume button is 'special' right now in that it doesn't currently receive the same [checked] background everything else does.  

One solution (in this patch) is to make it not special anymore, and then also fix all of the other [checked]:hover states to make it better.  This changes the UI a bit more (it becomes normal icon state with a blue bg instead of normal bg state with a blue icon), but it is more consistent with the rest of the tools.

Another option would be to get rid of the background: none on the resume button when it is [checked]:not(:hover) - in which case it will receive a blueish background on hover as opposed to the greyish one that the stepping buttons receive.

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8450203 [details] [diff] [review]
debugger-resume-button.patch

Review of attachment 8450203 [details] [diff] [review]:
-----------------------------------------------------------------

I like being consistent.

Comment 5

[Brian Grinstead [:bgrins]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=d52c0f1936a3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/9338670fcf90

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/9338670fcf90