1034138 - Get the native stack during a permanent thread hang

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: a. Get native stack for permahangs in BHM (v1)

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: b. Add thread hang native stack output to nsITelemetry;

nativeStack is set, in addition to stack, if we have a native stack for a particular hang.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: c. Display thread hang native stack in about:telemetry if available (v1)

Display native stack instead of pseudostack if available.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: d. Test BackgroundHangMonitor permahangs (v1)

Add simple test for permahang / native stack code, by causing a 10 second hang (which is treated as a permahang), and making sure we do have a native stack from the permahang.

Comment 5

[Vladan Djeric (:vladan)]

Comment on attachment 8453975 [details] [diff] [review]
b. Add thread hang native stack output to nsITelemetry;

Review of attachment 8453975 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Telemetry.cpp
@@ +2057,5 @@
>    return ret;
>  }
>  
>  static JSObject*
> +CreateJSHangStack(JSContext* cx, const Telemetry::HangStack& stack)

Let's rename this function since it will return both native & JS stacks

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0b4205c25e8
https://hg.mozilla.org/integration/mozilla-inbound/rev/e83ef20b70ff
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff782fb2e08e
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4cac20d25c9

Comment 7

[Carsten Book [:Tomcat]]

sorry had to back this changes in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=6ffcd2030ed8 since one of this changesets caused a nearly permanent error like https://tbpl.mozilla.org/php/getParsedLog.php?id=44598113&tree=Mozilla-Inbound

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: e. Don't log large amounts of data when running test_dbgsocket.js (v1)

test_dbgsocket.js is prone to timing out because we log all the "really long" data that we send, which apparently really stresses the test harness. This patch disables logging and hugely improves the test's performance.

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8463488 [details] [diff] [review]
e. Don't log large amounts of data when running test_dbgsocket.js (v1)

Review of attachment 8463488 [details] [diff] [review]:
-----------------------------------------------------------------

There are other tests in the same directory that will probably have similar issues.

Let's instead comment out the prefs that cause this (which is done[1] in various other DevTools directories), so that it's easy to enable in local debugging.

In this case, you'd comment out the two prefs here[2], and update / remove the comment above them.

[1]: http://hg.mozilla.org/mozilla-central/annotate/a4dcfbebcb58/browser/devtools/inspector/test/head.js#l11
[2]: http://hg.mozilla.org/mozilla-central/file/d77f6a96ff96/toolkit/devtools/transport/tests/unit/head_dbg.js#l21

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: e. Don't log large amounts of data when running devtools xpcshell tests (v2)

Thanks for the pointer!

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1453356019e7
https://hg.mozilla.org/integration/mozilla-inbound/rev/de4289ba35d6
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ee9b0913118
https://hg.mozilla.org/integration/mozilla-inbound/rev/a534d638ea6b
https://hg.mozilla.org/integration/mozilla-inbound/rev/89073e734ebb

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1453356019e7
https://hg.mozilla.org/mozilla-central/rev/de4289ba35d6
https://hg.mozilla.org/mozilla-central/rev/7ee9b0913118
https://hg.mozilla.org/mozilla-central/rev/a534d638ea6b
https://hg.mozilla.org/mozilla-central/rev/89073e734ebb