1034189 - Kuma: ./manage.py test apps/notifications fails

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
1. ./manage.py test apps/notifications

What happened?
==============
26 of 32 tests failed.  Two of the tests:

======================================================================
ERROR: Deleting an instance of MockModel should delete watches.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/src/vendor/src/django/django/test/testcases.py", line 502, in __call__
    self._pre_setup()
  File "/home/vagrant/src/apps/notifications/tests/__init__.py", line 49, in _pre_setup
    settings.INSTALLED_APPS.append(app)
AttributeError: 'tuple' object has no attribute 'append'

======================================================================
ERROR: Test that duplicate merging is case insensitive.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/src/apps/notifications/tests/test_events.py", line 244, in test_duplicates_case_insensitive
    AnotherEvent())._users_watching()]
  File "/home/vagrant/src/apps/notifications/events.py", line 475, in _users_watching
    reverse=True)
  File "/home/vagrant/src/apps/notifications/tests/test_events.py", line 236, in _users_watching
    return [(user(email='[e-mail]'), watch())]
  File "/home/vagrant/src/apps/notifications/tests/__init__.py", line 15, in watch
    w = Watch.objects.create(**defaults)
  File "/home/vagrant/src/vendor/src/django/django/db/models/manager.py", line 137, in create
    return self.get_query_set().create(**kwargs)
  File "/home/vagrant/src/vendor/src/django/django/db/models/query.py", line 377, in create
    obj.save(force_insert=True, using=self.db)
  File "/home/vagrant/src/vendor/src/django/django/db/models/base.py", line 463, in save
    self.save_base(using=using, force_insert=force_insert, force_update=force_update)
  File "/home/vagrant/src/vendor/src/django/django/db/models/base.py", line 551, in save_base
    result = manager._insert([self], fields=fields, return_id=update_pk, using=using, raw=raw)
  File "/home/vagrant/src/vendor/src/django/django/db/models/manager.py", line 203, in _insert
    return insert_query(self.model, objs, fields, **kwargs)
  File "/home/vagrant/src/vendor/src/django/django/db/models/query.py", line 1593, in insert_query
    return query.get_compiler(using=using).execute_sql(return_id)
  File "/home/vagrant/src/vendor/src/django/django/db/models/sql/compiler.py", line 912, in execute_sql
    cursor.execute(sql, params)
  File "/home/vagrant/src/vendor/src/django/django/db/backends/mysql/base.py", line 114, in execute
    return self.cursor.execute(query, args)
  File "/home/vagrant/env/lib/python2.6/site-packages/MySQLdb/cursors.py", line 173, in execute
    self.errorhandler(self, exc, value)
  File "/home/vagrant/env/lib/python2.6/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
    raise errorclass, errorvalue
DatabaseError: (1146, "Table 'test_kuma.notifications_watch' doesn't exist")

What should have happened?
==========================
No failures

Is there anything else we should know?
======================================

Comment 1

[Jannis Leidel [:jezdez]]

I think this app isn't actually used anymore, can you clarify Luke?

Comment 2

[Jannis Leidel [:jezdez]]

Luke replied on IRC: "jezdez: oh, hmm ... notifications pre-dates tidings I think"

Which makes sense, I take it this means the notifications app can be removed.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/3bd6824c32ce6ac458f94dcf0ef0fa5531faaea3
fix bug 1034189 - remove notifications app.

The app is a left over from before django-tidings replaced it.

https://github.com/mozilla/kuma/commit/5444d60d7246e104e875eec823d992821bcf70f4
Merge pull request #2802 from jezdez/bug1034189

fix bug 1034189 - remove notifications app.