Closed
Bug 1034201
Opened 11 years ago
Closed 11 years ago
Clarify inline code snippets with alternate styling
Categories
(Websites :: wiki.mozilla.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2014-Q3
People
(Reporter: gene, Unassigned)
References
Details
(Whiteboard: [gmo])
Currently inline code snippets, using the <code> tag are rendered like this
http://i.imgur.com/RgxqfgI.png
This styling makes it difficult to differentiate between the code and the surrounding text as the only differentiator is the change from a variable width font to a fixed width font.
Github uses, in my opinion, an excellent styling to call out inline code by
* surrounding the span in a box
* using a different background
I've put together a PR here :
https://github.com/mozilla/mediawiki-skins-gmo/pull/6
which adds a <code> style css block which creates a clearer styling. With this style in place, inline code now looks like this :
http://i.imgur.com/eNbC4ur.png
Please take a look at this PR and if it looks good, merge. Thanks!
Reporter | ||
Comment 1•11 years ago
|
||
:ckoehler, how does this PR look? Suggestions? Something we can merge?
Flags: needinfo?(ckoehler)
Reporter | ||
Comment 2•11 years ago
|
||
:ckohler, have you had a chance to take a look at my PR? Shouldn't take more than a minute or two, it's pretty small.
Reporter | ||
Comment 3•11 years ago
|
||
I meant :ckoehler not :ckohler
Updated•11 years ago
|
Whiteboard: [gmo]
Comment 4•11 years ago
|
||
PR merged on github. Filed bug 1044482 to have theme updated on dev, stage and prod.
Sorry for the delay!
Comment 5•11 years ago
|
||
This has been deployed to production.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(ckoehler)
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 2014-Q3
You need to log in
before you can comment on or make changes to this bug.
Description
•