1034271 - [SMS] Background graphic is out of date

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Amy Lee [:amylee] UX]

The chat bubble graphic background in SMS when you have no messages is out of date and needs to be updated. I am assuming the graphic is a transparent png. Pavel, if you have time to take this bug can you please confirm that it is a transparent .png that I need to provide in @1, @1.5, @2, and @2.25 sizes? 

Thanks

Comment 1

[Amy Lee [:amylee] UX]

Attachment: 2014-07-03-16-27-02.png

Screenshot of chat bubble background that needs to be updated

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Amy, here is the current file: https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/SMS_200x200_bubble.png

(and I notice the 2.25x asset is badly named and won't show up in current code...)


Amy, is it you or Vicky (from TEF, our usual VD) who should provide the updated image?

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Sure I will take it,
just need all of the versions of that image @1x, @1.5x, @2x, @2.25x

Thanks :)

Comment 4

[Victoria Gerchinhoren [:vicky]]

It looks like this is taken care of. So removing NI.

Comment 5

[Amy Lee [:amylee] UX]

Attachment: Chat_Bubble.zip

Hi

Here is the chat bubble graphic to be updated. Thanks!

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: 2014-07-04-21-48-00.png

Hey, here is the screenshot of the patch.

To me, the bubble looks slightly too high, but please tell us what you think.

Comment 8

[Amy Lee [:amylee] UX]

Comment on attachment 8451149 [details]
2014-07-04-21-48-00.png

Hi, 

Yeah I agree. I looked at the graphic in the contacts app and it's vertically centered to the screen. I think the position should match on all the apps. Can you vertically center the graphic to the white space? Thanks

Comment 9

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8451103 [details] [review]
patch for Gaia/master

What Amy said.

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

Here is a shot with vertically center the graphic to the white space.

Comment 11

[Amy Lee [:amylee] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #10)
> Created attachment 8451471 [details]
> After patch screenshot
> 
> Here is a shot with vertically center the graphic to the white space.

Hi Pavel, 

Can you send me the patch for the new version? I just want to see it on the Flame device. Thanks!

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Amy,
my PR is up to date you can check it

Comment 13

[Amy Lee [:amylee] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #12)
> Hey Amy,
> my PR is up to date you can check it

Hey Pavel, 

Can you send me a screenshot of the flame? The patch didn't update :-(

Comment 14

[Amy Lee [:amylee] UX]

See above. Thanks!

Comment 15

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot on Flame

Comment 16

[Amy Lee [:amylee] UX]

Comment on attachment 8453935 [details]
After patch screenshot on Flame

Looks good. Thanks!

Comment 17

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8451103 [details] [review]
patch for Gaia/master

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: low: invalid image in the background of the SMS app that has no messages
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none

Comment 18

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

master: ce6a9e7cf5eb51843766908b8bcb7e8a64eecfc9

Comment 19

[bhavana bajaj [:bajaj]]

Comment on attachment 8451103 [details] [review]
patch for Gaia/master

low risk css change, looks good to land with ux review+

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/0dfee003546e67aa66e7bcd795a007d382378ef9

Comment 21

[Sue]

Attachment: screenshot of Flame 2.0

Comment 22

[Sue]

Attachment: screenshot of flame 2.1

Comment 23

[Sue]

This issue has been verified successfully on Flame v2.1 & v2.0
See attachment: Flame 2.0.png and Flame 2.1.png
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880

Flame 2.0 versions:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141207000206
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141207.034341
FW-Date         Sun Dec  7 03:43:52 EST 2014
Bootloader      L1TC00011880