Closed
Bug 1034412
Opened 11 years ago
Closed 11 years ago
Clarify value of der::SEQUENCE
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(1 file)
884 bytes,
patch
|
mmc
:
review+
|
Details | Diff | Splinter Review |
ASN.1 SEQUENCE has a tag value of 0x10, but since SEQUENCEs are always constructed we include CONSTRUCTED into the value of der::SEQUENCE, so that the resulting value is 0x30. But, there is a typo in the definition of der::SEQUENCE that makes this more confusing than it needs to be. This patch fixes that typo.
Assignee | ||
Updated•11 years ago
|
Attachment #8450737 -
Attachment is patch: true
Attachment #8450737 -
Attachment mime type: text/x-patch → text/plain
Attachment #8450737 -
Flags: review?(mmc)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → brian
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla33
Updated•11 years ago
|
Attachment #8450737 -
Flags: review?(mmc) → review+
Assignee | ||
Comment 1•11 years ago
|
||
Thanks for the wicked-fast review (on a holiday even)!
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f33ff1a46a4
Comment 2•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•