Closed Bug 1034550 Opened 10 years ago Closed 10 years ago

[Loop][CallLog] Implement UI based on the data retrieved from the ActionsLogDB Helper

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

Attachments

(1 file)

Pull Request
60 bytes, text/x-github-pull-request
ferjm
: review+
jaoo
: feedback+
ferjm
: feedback+
Details | Review 
Based on the data retrieved from ActionsLogDB Helper we will render the UI in order to let the user check & update it own log of actions with Loop.
Assignee: nobody → borja.bugzilla
Blocks: Loopmov_1_1, loop_call_log, 1007659, 1008105, 1009045, 1014470
Depends on: 1034544
Blocks: 1035693
Attached file Pull Request — 

    
  

        Attachment #8452395 -
        Flags: review?(josea.olivera)

    
  

        Attachment #8452395 -
        Flags: review?(ferjmoreno)

    
  
Blocks: 1036309

    
    

    
  
Comment on attachment 8452395 [details] [review]
Pull Request

The patch LGTM but I would like Fernando to take a look and review this as he knows better about the call log stuff. Thanks!

        Attachment #8452395 -
        Flags: review?(josea.olivera) → feedback+

    
    

    
  
Comment on attachment 8452395 [details] [review]
Pull Request

Excellent job!

The only major thing is the comment about getting and rendering the urls before the user clicks in the urls tabs. We shouldn't process stuff that we are not going to show in the screen on the first paint.

        Attachment #8452395 -
        Flags: review?(ferjmoreno) → feedback+

    
  
Blocks: 1036351

    
  

        Attachment #8452395 -
        Flags: review?(ferjmoreno)

        Attachment #8452395 -
        Flags: review?(ferjmoreno) → review+

    
  
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: