1034560 - Utility tray is closed when the airplanemode button is pressed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Marina Rodríguez [:mai]]

When I press the button airplanemode after slide down the utility tray, the utility try is closed automaticatly and when I review the logcat report I can't see any error. 

This behaviour does not occurs on previous verions of gaia.

Regards

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

I don't know what to say but I guess it's related to AirplaneMode refactor.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Can QA help verify this bug ? thanks

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I am trying to find the root cause, after doing a quick bisect on my side, https://github.com/mozilla-b2g/gaia/pull/20626 is the first PR which causes the problem but I don't see any relation with this bug.

Still trying to figure out what's going on.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Guilherme, 

Please check https://github.com/mozilla-b2g/gaia/pull/20626/files#diff-b3da56bd5d6a67d5766cef2d709c38f0R45

Why findmydevice observe the value change in settings `geolocation.enabled` ?? This will make this bug happen when toggling airplanemode. Maybe you guys have to change the way to do something ? 

Please check my bisect result for more information.

Comment 5

[Guilherme Gonçalves [:ggp]]

We observe 'geolocation.enabled' because we need to notify the server when geolocation is disabled on the device, as that gets reflected in the web interface. Contacting the server requires launching the Find My Device app, and it looks like that causes a 'launchapp' event to be fired [1], which closes the utility tray.

Find My Device is a background app with no interface at all, and it can be launched by the system itself (with no user interaction) based on alarms and push notifications. So this geolocation issue is not really the only case in which the utility tray may close unexpectedly, and I think the proper fix for this is to not call |this.hide()| in the conditional when a background app is launched. Is something like that possible?

1- https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/utility_tray.js#L90

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

We confirm the bug and then branch check first before finding a window. Replacing to appropriate tag.

Comment 7

[Pi Wei Cheng [:piwei] (inactive)]

Able to reproduce this bug on Flame 2.0 Aurora, Flame 2.1 master, and Buri 2.1 master.

Observed: Tapping on Airplane icon in utility tray causes the tray to close by itself. The tray can still be pulled down after that.

Device: Flame
Build ID: 20140721000201
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame
Build ID: 20140721055837
Gaia: Unknown
Gecko: 0dc711216018
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Device: Buri
Build ID: 20140721055837
Gaia: Unknown
Gecko: 0dc711216018
Version: 33.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

-------------

Issue is NOT reproducible on Flame 1.4.

Observed: Utility tray remains open after tapping on Airplane icon.

Device: Flame 1.4
Build ID: 20140721000201
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 83b7be7fb33f
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 8

[Joshua Mitchell (Inactive)]

(In reply to Pi Wei Cheng [:piwei] from comment #6)
> We confirm the bug and then branch check first before finding a window.
> Replacing to appropriate tag.

I don't believe they were asking for a window anyway - just the branch checks you provided. "verify"

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

@alive,

please check comment 5, in this way, any suggestion for this patch ? Can we use `role=system` to check this special case when we get `launchapp` event ? any feedback is appreciated !

THanks !

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Not every role="system" app is guaranteed to be UI-less. So I don't think it's reasonable to do that...

The only possible fix might be blacklist the manifestURL of FMD, and since this is so bad let's see if this bug is blocker or not to do it.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Ok thanks Alive, let's wait for the decision and see what to do next !

Comment 12

[Jason Smith [:jsmith]]

Josh - I think this bug is missing the regression keyword & a blocking triage analysis. Can you fix this?

Comment 13

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]:

blocking triage analysis - I would nom this as a blocker - it is very peculiar and abrupt behaviour that is not consistent with other notification menu icon behaviour.  It potentially has high visibility as airplane mode is a quick work-around to turn off power-hungry features (wifi, bluetooth) with one easy button-press.

Comment 14

[Gregor Wagner [:gwagner]]

Is this a regression from bug 1025193?

Comment 15

[Gregor Wagner [:gwagner]]

Lets see if UX thinks this is a critical blocker.

Comment 16

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1025193 is in the window where this issue occurs.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame Master
BuildID: 20140620093242
Gaia: 008b5a4d1be8cb8416543047a748681cc70ea193
Gecko: 10587a9e7686
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken 
Environmental Variables:
Device: Flame Master
BuildID: 20140620113243
Gaia: 6bf7dc1a2d7f6eef651d6e4932fae8e7d70a27dd
Gecko: d40680e24efe
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Last working gaia / First broken gecko - Issue does NOT occur
Gaia: 008b5a4d1be8cb8416543047a748681cc70ea193
Gecko: d40680e24efe

First broken gaia / Last working gecko - Issue DOES occur
Gaia: 6bf7dc1a2d7f6eef651d6e4932fae8e7d70a27dd
Gecko: 10587a9e7686

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/008b5a4d1be8cb8416543047a748681cc70ea193...6bf7dc1a2d7f6eef651d6e4932fae8e7d70a27dd

Comment 17

[Gregor Wagner [:gwagner]]

EJ, are you working on this or do you want Guilherme to take a look?

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Gregor Wagner [:gwagner] from comment #17)
> EJ, are you working on this or do you want Guilherme to take a look?

I can work on this and it's ok for me. And by the way, I just made a quick patch for this.

Base on comment 10, we are still waiting for triaging result to see what to do next.

Thanks Gregor.

Comment 19

[Gregor Wagner [:gwagner]]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #18)
> (In reply to Gregor Wagner [:gwagner] from comment #17)
> > EJ, are you working on this or do you want Guilherme to take a look?
> 
> I can work on this and it's ok for me. And by the way, I just made a quick
> patch for this.
> 
> Base on comment 10, we are still waiting for triaging result to see what to
> do next.
> 
> Thanks Gregor.

Thanks for the update!

Comment 20

[Stephany Wilkes]

This appears to be a regression and thus a blocker. No extra UX blocking needed here; the regression status alone will block, no?

Comment 21

[bhavana bajaj [:bajaj]]

(In reply to Stephany Wilkes from comment #20)
> This appears to be a regression and thus a blocker. No extra UX blocking
> needed here; the regression status alone will block, no?

typically yes, but if its a regression we can live with for a release and keeping the ship timeline we may have to take a hit sometimes, hence the expert opinion here helps :)

Comment 22

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Hi alive, can you help me check this patch and see whether it makes sense or not ? 

Based on our discussions above, I made a blacklist to block background apps and don't make the utility tray hide when `launchapp` event is emitted.

Thanks !

Comment 23

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8464473 [details] [review]
patch on master

r+ with nit

Comment 24

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, merged into Gaia/master: https://github.com/mozilla-b2g/gaia/commit/31285b589c888d568499e3ded096210b2a578729

Comment 25

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on v2.0

This is the same patch cherry-picked from master

Comment 26

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I found a small problem on master patch, so just reverted it here https://github.com/mozilla-b2g/gaia/commit/965a7a2c6e3ab0e2dabcbbce69156dfb17403ccc

Comment 27

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

@alive, I just found a mistake in testfile that would break tests. Our original code would fail on 2.0 but not sure why it is green on master (I even got the failure running on my local), so I reverted the old one and made a new one.

Please help me review this, thanks :)

Comment 28

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8466849 [details] [review]
patch on v2.0

And also this 2.0 patch (they are the same, but it would help me check whether i break anything on tbpl).

Thanks !

Comment 29

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all ! 

patches are merged into

Gaia/master: https://github.com/mozilla-b2g/gaia/pull/22475
Gaia/v2.0: https://github.com/mozilla-b2g/gaia/pull/22458

Comment 30

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.0 and 2.1
See attachment: Verify_1034600.MP4
Reproducing rate: 0/5
Reproducing steps:
1. Slide down the utility tray.
2. Tap airplane mode button.
** The utility tray doesn’t close automatically.

Flame 2.0 build:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141208000206
Version         32.0

Flame 2.1 build:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0